read_packed_refs(): use mmap to read the `packed-refs` file

diff --git a/refs/packed-backend.c b/refs/packed-backend.c
index a3d9210cb057bd64242a988a23e4aa5aad5730d5..154abbd83a5d9e0d54cef8b1f9e7479da0c6d456 100644 (file)
--- a/refs/packed-backend.c
+++ b/refs/packed-backend.c
@@ -161,6 +161,29 @@ static const char *parse_ref_line(struct strbuf *line, struct object_id *oid)
        return ref;
 }
 
+static NORETURN void die_unterminated_line(const char *path,
+                                          const char *p, size_t len)
+{
+       if (len < 80)
+               die("unterminated line in %s: %.*s", path, (int)len, p);
+       else
+               die("unterminated line in %s: %.75s...", path, p);
+}
+
+static NORETURN void die_invalid_line(const char *path,
+                                     const char *p, size_t len)
+{
+       const char *eol = memchr(p, '\n', len);
+
+       if (!eol)
+               die_unterminated_line(path, p, len);
+       else if (eol - p < 80)
+               die("unexpected line in %s: %.*s", path, (int)(eol - p), p);
+       else
+               die("unexpected line in %s: %.75s...", path, p);
+
+}
+
 /*
  * Read from the `packed-refs` file into a newly-allocated
  * `packed_ref_cache` and return it. The return value will already
@@ -192,8 +215,12 @@ static const char *parse_ref_line(struct strbuf *line, struct object_id *oid)
  */
 static struct packed_ref_cache *read_packed_refs(struct packed_ref_store *refs)
 {
-       FILE *f;
        struct packed_ref_cache *packed_refs = xcalloc(1, sizeof(*packed_refs));
+       int fd;
+       struct stat st;
+       size_t size;
+       char *buf;
+       const char *pos, *eol, *eof;
        struct ref_entry *last = NULL;
        struct strbuf line = STRBUF_INIT;
        enum { PEELED_NONE, PEELED_TAGS, PEELED_FULLY } peeled = PEELED_NONE;
@@ -204,8 +231,8 @@ static struct packed_ref_cache *read_packed_refs(struct packed_ref_store *refs)
        packed_refs->cache = create_ref_cache(NULL, NULL);
        packed_refs->cache->root->flag &= ~REF_INCOMPLETE;
 
-       f = fopen(refs->path, "r");
-       if (!f) {
+       fd = open(refs->path, O_RDONLY);
+       if (fd < 0) {
                if (errno == ENOENT) {
                        /*
                         * This is OK; it just means that no
@@ -218,16 +245,27 @@ static struct packed_ref_cache *read_packed_refs(struct packed_ref_store *refs)
                }
        }
 
-       stat_validity_update(&packed_refs->validity, fileno(f));
+       stat_validity_update(&packed_refs->validity, fd);
+
+       if (fstat(fd, &st) < 0)
+               die_errno("couldn't stat %s", refs->path);
+
+       size = xsize_t(st.st_size);
+       buf = xmmap(NULL, size, PROT_READ, MAP_PRIVATE, fd, 0);
+       pos = buf;
+       eof = buf + size;
 
        dir = get_ref_dir(packed_refs->cache->root);
-       while (strbuf_getwholeline(&line, f, '\n') != EOF) {
+       while (pos < eof) {
                struct object_id oid;
                const char *refname;
                const char *traits;
 
-               if (!line.len || line.buf[line.len - 1] != '\n')
-                       die("unterminated line in %s: %s", refs->path, line.buf);
+               eol = memchr(pos, '\n', eof - pos);
+               if (!eol)
+                       die_unterminated_line(refs->path, pos, eof - pos);
+
+               strbuf_add(&line, pos, eol + 1 - pos);
 
                if (skip_prefix(line.buf, "# pack-refs with:", &traits)) {
                        if (strstr(traits, " fully-peeled "))
@@ -235,7 +273,7 @@ static struct packed_ref_cache *read_packed_refs(struct packed_ref_store *refs)
                        else if (strstr(traits, " peeled "))
                                peeled = PEELED_TAGS;
                        /* perhaps other traits later as well */
-                       continue;
+                       goto next_line;
                }
 
                refname = parse_ref_line(&line, &oid);
@@ -266,14 +304,20 @@ static struct packed_ref_cache *read_packed_refs(struct packed_ref_store *refs)
                         */
                        last->flag |= REF_KNOWS_PEELED;
                } else {
-                       strbuf_setlen(&line, line.len - 1);
-                       die("unexpected line in %s: %s", refs->path, line.buf);
+                       die_invalid_line(refs->path, line.buf, line.len);
                }
+
+       next_line:
+               /* The "+ 1" is for the LF character. */
+               pos = eol + 1;
+               strbuf_reset(&line);
        }
 
-       fclose(f);
-       strbuf_release(&line);
+       if (munmap(buf, size))
+               die_errno("error ummapping packed-refs file");
+       close(fd);
 
+       strbuf_release(&line);
        return packed_refs;
 }