send-pack --keep: do not explode into loose objects on the receiving end.
[gitweb.git] / upload-pack.c
index 2b70c3dcb4e3b1e73d7d5a088ae73de17540b6b7..9ec3775049a44bf1ffdc145240e6d7cdea303b91 100644 (file)
@@ -1,27 +1,29 @@
+#include <signal.h>
+#include <sys/wait.h>
+#include <sys/poll.h>
 #include "cache.h"
 #include "refs.h"
 #include "pkt-line.h"
+#include "sideband.h"
 #include "tag.h"
 #include "object.h"
 #include "commit.h"
 #include "exec_cmd.h"
-#include <signal.h>
-#include <sys/poll.h>
-#include <sys/wait.h>
 
 static const char upload_pack_usage[] = "git-upload-pack [--strict] [--timeout=nn] <dir>";
 
 #define THEY_HAVE (1U << 0)
 #define OUR_REF (1U << 1)
 #define WANTED (1U << 2)
-#define MAX_HAS 256
-#define MAX_NEEDS 256
-static int nr_has = 0, nr_needs = 0, multi_ack = 0, nr_our_refs = 0;
-static int use_thin_pack = 0;
-static unsigned char has_sha1[MAX_HAS][20];
-static unsigned char needs_sha1[MAX_NEEDS][20];
-static unsigned int timeout = 0;
-static int use_sideband = 0;
+static int multi_ack, nr_our_refs;
+static int use_thin_pack, use_ofs_delta;
+static struct object_array have_obj;
+static struct object_array want_obj;
+static unsigned int timeout;
+/* 0 for no sideband,
+ * otherwise maximum packet size (up to 65520 bytes).
+ */
+static int use_sideband;
 
 static void reset_timeout(void)
 {
@@ -35,41 +37,18 @@ static int strip(char *line, int len)
        return len;
 }
 
-#define PACKET_MAX 1000
 static ssize_t send_client_data(int fd, const char *data, ssize_t sz)
 {
-       ssize_t ssz;
-       const char *p;
-
-       if (!data) {
-               if (!use_sideband)
-                       return 0;
-               packet_flush(1);
-       }
-
-       if (!use_sideband) {
-               if (fd == 3)
-                       /* emergency quit */
-                       fd = 2;
-               return safe_write(fd, data, sz);
+       if (use_sideband)
+               return send_sideband(1, fd, data, sz, use_sideband);
+       if (fd == 3)
+               /* emergency quit */
+               fd = 2;
+       if (fd == 2) {
+               xwrite(fd, data, sz);
+               return sz;
        }
-       p = data;
-       ssz = sz;
-       while (sz) {
-               unsigned n;
-               char hdr[5];
-
-               n = sz;
-               if (PACKET_MAX - 5 < n)
-                       n = PACKET_MAX - 5;
-               sprintf(hdr, "%04x", n + 5);
-               hdr[4] = fd;
-               safe_write(1, hdr, 5);
-               safe_write(1, p, n);
-               p += n;
-               sz -= n;
-       }
-       return ssz;
+       return safe_write(fd, data, sz);
 }
 
 static void create_pack_file(void)
@@ -79,7 +58,7 @@ static void create_pack_file(void)
         */
        int lp_pipe[2], pu_pipe[2], pe_pipe[2];
        pid_t pid_rev_list, pid_pack_objects;
-       int create_full_pack = (nr_our_refs == nr_needs && !nr_has);
+       int create_full_pack = (nr_our_refs == want_obj.nr && !have_obj.nr);
        char data[8193], progress[128];
        char abort_msg[] = "aborting due to possible repository "
                "corruption on the remote side.";
@@ -103,7 +82,7 @@ static void create_pack_file(void)
                        use_thin_pack = 0; /* no point doing it */
                }
                else
-                       args = nr_has + nr_needs + 5;
+                       args = have_obj.nr + want_obj.nr + 5;
                p = xmalloc(args * sizeof(char *));
                argv = (const char **) p;
                buf = xmalloc(args * 45);
@@ -114,20 +93,22 @@ static void create_pack_file(void)
                close(lp_pipe[1]);
                *p++ = "rev-list";
                *p++ = use_thin_pack ? "--objects-edge" : "--objects";
-               if (create_full_pack || MAX_NEEDS <= nr_needs)
+               if (create_full_pack)
                        *p++ = "--all";
                else {
-                       for (i = 0; i < nr_needs; i++) {
+                       for (i = 0; i < want_obj.nr; i++) {
+                               struct object *o = want_obj.objects[i].item;
                                *p++ = buf;
-                               memcpy(buf, sha1_to_hex(needs_sha1[i]), 41);
+                               memcpy(buf, sha1_to_hex(o->sha1), 41);
                                buf += 41;
                        }
                }
                if (!create_full_pack)
-                       for (i = 0; i < nr_has; i++) {
+                       for (i = 0; i < have_obj.nr; i++) {
+                               struct object *o = have_obj.objects[i].item;
                                *p++ = buf;
                                *buf++ = '^';
-                               memcpy(buf, sha1_to_hex(has_sha1[i]), 41);
+                               memcpy(buf, sha1_to_hex(o->sha1), 41);
                                buf += 41;
                        }
                *p++ = NULL;
@@ -156,7 +137,9 @@ static void create_pack_file(void)
                close(pu_pipe[1]);
                close(pe_pipe[0]);
                close(pe_pipe[1]);
-               execl_git_cmd("pack-objects", "--stdout", "--progress", NULL);
+               execl_git_cmd("pack-objects", "--stdout", "--progress",
+                             use_ofs_delta ? "--delta-base-offset" : NULL,
+                             NULL);
                kill(pid_rev_list, SIGKILL);
                die("git-upload-pack: unable to exec git-pack-objects");
        }
@@ -178,6 +161,8 @@ static void create_pack_file(void)
                ssize_t sz;
                int pe, pu, pollsize;
 
+               reset_timeout();
+
                pollsize = 0;
                pe = pu = -1;
 
@@ -302,7 +287,8 @@ static void create_pack_file(void)
                                goto fail;
                        fprintf(stderr, "flushed.\n");
                }
-               send_client_data(1, NULL, 0);
+               if (use_sideband)
+                       packet_flush(1);
                return;
        }
  fail:
@@ -316,35 +302,37 @@ static void create_pack_file(void)
 
 static int got_sha1(char *hex, unsigned char *sha1)
 {
+       struct object *o;
+
        if (get_sha1_hex(hex, sha1))
                die("git-upload-pack: expected SHA1 object, got '%s'", hex);
        if (!has_sha1_file(sha1))
                return 0;
-       if (nr_has < MAX_HAS) {
-               struct object *o = lookup_object(sha1);
-               if (!(o && o->parsed))
-                       o = parse_object(sha1);
-               if (!o)
-                       die("oops (%s)", sha1_to_hex(sha1));
-               if (o->type == TYPE_COMMIT) {
-                       struct commit_list *parents;
-                       if (o->flags & THEY_HAVE)
-                               return 0;
-                       o->flags |= THEY_HAVE;
-                       for (parents = ((struct commit*)o)->parents;
-                            parents;
-                            parents = parents->next)
-                               parents->item->object.flags |= THEY_HAVE;
-               }
-               memcpy(has_sha1[nr_has++], sha1, 20);
+
+       o = lookup_object(sha1);
+       if (!(o && o->parsed))
+               o = parse_object(sha1);
+       if (!o)
+               die("oops (%s)", sha1_to_hex(sha1));
+       if (o->type == OBJ_COMMIT) {
+               struct commit_list *parents;
+               if (o->flags & THEY_HAVE)
+                       return 0;
+               o->flags |= THEY_HAVE;
+               for (parents = ((struct commit*)o)->parents;
+                    parents;
+                    parents = parents->next)
+                       parents->item->object.flags |= THEY_HAVE;
        }
+       add_object_array(o, NULL, &have_obj);
        return 1;
 }
 
 static int get_common_commits(void)
 {
        static char line[1000];
-       unsigned char sha1[20], last_sha1[20];
+       unsigned char sha1[20];
+       char hex[41], last_hex[41];
        int len;
 
        track_object_refs = 0;
@@ -355,29 +343,28 @@ static int get_common_commits(void)
                reset_timeout();
 
                if (!len) {
-                       if (nr_has == 0 || multi_ack)
+                       if (have_obj.nr == 0 || multi_ack)
                                packet_write(1, "NAK\n");
                        continue;
                }
                len = strip(line, len);
                if (!strncmp(line, "have ", 5)) {
-                       if (got_sha1(line+5, sha1) &&
-                                       (multi_ack || nr_has == 1)) {
-                               if (nr_has >= MAX_HAS)
-                                       multi_ack = 0;
-                               packet_write(1, "ACK %s%s\n",
-                                       sha1_to_hex(sha1),
-                                       multi_ack ?  " continue" : "");
-                               if (multi_ack)
-                                       memcpy(last_sha1, sha1, 20);
+                       if (got_sha1(line+5, sha1)) {
+                               memcpy(hex, sha1_to_hex(sha1), 41);
+                               if (multi_ack) {
+                                       const char *msg = "ACK %s continue\n";
+                                       packet_write(1, msg, hex);
+                                       memcpy(last_hex, hex, 41);
+                               }
+                               else if (have_obj.nr == 1)
+                                       packet_write(1, "ACK %s\n", hex);
                        }
                        continue;
                }
                if (!strcmp(line, "done")) {
-                       if (nr_has > 0) {
+                       if (have_obj.nr > 0) {
                                if (multi_ack)
-                                       packet_write(1, "ACK %s\n",
-                                                       sha1_to_hex(last_sha1));
+                                       packet_write(1, "ACK %s\n", last_hex);
                                return 0;
                        }
                        packet_write(1, "NAK\n");
@@ -387,39 +374,33 @@ static int get_common_commits(void)
        }
 }
 
-static int receive_needs(void)
+static void receive_needs(void)
 {
        static char line[1000];
-       int len, needs;
+       int len;
 
-       needs = 0;
        for (;;) {
                struct object *o;
-               unsigned char dummy[20], *sha1_buf;
+               unsigned char sha1_buf[20];
                len = packet_read_line(0, line, sizeof(line));
                reset_timeout();
                if (!len)
-                       return needs;
-
-               sha1_buf = dummy;
-               if (needs == MAX_NEEDS) {
-                       fprintf(stderr,
-                               "warning: supporting only a max of %d requests. "
-                               "sending everything instead.\n",
-                               MAX_NEEDS);
-               }
-               else if (needs < MAX_NEEDS)
-                       sha1_buf = needs_sha1[needs];
+                       return;
 
-               if (strncmp("want ", line, 5) || get_sha1_hex(line+5, sha1_buf))
+               if (strncmp("want ", line, 5) ||
+                   get_sha1_hex(line+5, sha1_buf))
                        die("git-upload-pack: protocol error, "
                            "expected to get sha, not '%s'", line);
                if (strstr(line+45, "multi_ack"))
                        multi_ack = 1;
                if (strstr(line+45, "thin-pack"))
                        use_thin_pack = 1;
-               if (strstr(line+45, "side-band"))
-                       use_sideband = 1;
+               if (strstr(line+45, "ofs-delta"))
+                       use_ofs_delta = 1;
+               if (strstr(line+45, "side-band-64k"))
+                       use_sideband = LARGE_PACKET_MAX;
+               else if (strstr(line+45, "side-band"))
+                       use_sideband = DEFAULT_PACKET_MAX;
 
                /* We have sent all our refs already, and the other end
                 * should have chosen out of them; otherwise they are
@@ -434,14 +415,14 @@ static int receive_needs(void)
                        die("git-upload-pack: not our ref %s", line+5);
                if (!(o->flags & WANTED)) {
                        o->flags |= WANTED;
-                       needs++;
+                       add_object_array(o, NULL, &want_obj);
                }
        }
 }
 
 static int send_ref(const char *refname, const unsigned char *sha1)
 {
-       static const char *capabilities = "multi_ack thin-pack side-band";
+       static const char *capabilities = "multi_ack thin-pack side-band side-band-64k ofs-delta";
        struct object *o = parse_object(sha1);
 
        if (!o)
@@ -457,25 +438,24 @@ static int send_ref(const char *refname, const unsigned char *sha1)
                o->flags |= OUR_REF;
                nr_our_refs++;
        }
-       if (o->type == TYPE_TAG) {
+       if (o->type == OBJ_TAG) {
                o = deref_tag(o, refname, 0);
                packet_write(1, "%s %s^{}\n", sha1_to_hex(o->sha1), refname);
        }
        return 0;
 }
 
-static int upload_pack(void)
+static void upload_pack(void)
 {
        reset_timeout();
        head_ref(send_ref);
        for_each_ref(send_ref);
        packet_flush(1);
-       nr_needs = receive_needs();
-       if (!nr_needs)
-               return 0;
-       get_common_commits();
-       create_pack_file();
-       return 0;
+       receive_needs();
+       if (want_obj.nr) {
+               get_common_commits();
+               create_pack_file();
+       }
 }
 
 int main(int argc, char **argv)