Merge branch 'jk/write-in-full-fix' into maint

diff --git a/transport-helper.c b/transport-helper.c
index 2128a32f1cd11b96b63c03aa4e38cb43e08fc546..a72ed18efbfeedffb217a3d66daa9f2626cf6479 100644 (file)
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -1116,6 +1116,13 @@ int transport_helper_init(struct transport *transport, const char *name)
 __attribute__((format (printf, 1, 2)))
 static void transfer_debug(const char *fmt, ...)
 {
+       /*
+        * NEEDSWORK: This function is sometimes used from multiple threads, and
+        * we end up using debug_enabled racily. That "should not matter" since
+        * we always write the same value, but it's still wrong. This function
+        * is listed in .tsan-suppressions for the time being.
+        */
+
        va_list args;
        char msgbuf[PBUFFERSIZE];
        static int debug_enabled = -1;