git-gui: Bind Tab/Shift-Tab to cycle between panes in blame

diff --git a/lib/console.tcl b/lib/console.tcl
index e40ec9639bdf053969e0dd0716119607a8cd7d43..ce25d92cac7b7826d8e04adc18d6e8a3c133096d 100644 (file)
--- a/lib/console.tcl
+++ b/lib/console.tcl
@@ -1,22 +1,29 @@
 # git-gui console support
 # Copyright (C) 2006, 2007 Shawn Pearce
 
-set next_console_id 0
-
-proc new_console {short_title long_title} {
-       global next_console_id console_data
-       set w .console[incr next_console_id]
-       set console_data($w) [list $short_title $long_title]
-       return [console_init $w]
+class console {
+
+field t_short
+field t_long
+field w
+field console_cr
+
+constructor new {short_title long_title} {
+       set t_short $short_title
+       set t_long $long_title
+       _init $this
+       return $this
 }
 
-proc console_init {w} {
-       global console_cr console_data M1B
+method _init {} {
+       global M1B
+       make_toplevel top w -autodelete 0
+       wm title $top "[appname] ([reponame]): $t_short"
+       set console_cr 1.0
 
-       set console_cr($w) 1.0
-       toplevel $w
        frame $w.m
-       label $w.m.l1 -text "[lindex $console_data($w) 1]:" \
+       label $w.m.l1 \
+               -textvariable @t_long  \
                -anchor w \
                -justify left \
                -font font_uibold
@@ -59,11 +66,9 @@ proc console_init {w} {
        bind $w.m.t <$M1B-Key-a> "$w.m.t tag add sel 0.0 end;break"
        bind $w.m.t <$M1B-Key-A> "$w.m.t tag add sel 0.0 end;break"
        bind $w <Visibility> "focus $w"
-       wm title $w "[appname] ([reponame]): [lindex $console_data($w) 0]"
-       return $w
 }
 
-proc console_exec {w cmd after} {
+method exec {cmd {after {}}} {
        # -- Cygwin's Tcl tosses the enviroment when we exec our child.
        #    But most users need that so we have to relogin. :-(
        #
@@ -78,15 +83,13 @@ proc console_exec {w cmd after} {
 
        set fd_f [open $cmd r]
        fconfigure $fd_f -blocking 0 -translation binary
-       fileevent $fd_f readable [list console_read $w $fd_f $after]
+       fileevent $fd_f readable [cb _read $fd_f $after]
 }
 
-proc console_read {w fd after} {
-       global console_cr
-
+method _read {fd after} {
        set buf [read $fd]
        if {$buf ne {}} {
-               if {![winfo exists $w]} {console_init $w}
+               if {![winfo exists $w.m.t]} {_init $this}
                $w.m.t conf -state normal
                set c 0
                set n [string length $buf]
@@ -98,11 +101,11 @@ proc console_read {w fd after} {
 
                        if {$lf < $cr} {
                                $w.m.t insert end [string range $buf $c $lf]
-                               set console_cr($w) [$w.m.t index {end -1c}]
+                               set console_cr [$w.m.t index {end -1c}]
                                set c $lf
                                incr c
                        } else {
-                               $w.m.t delete $console_cr($w) end
+                               $w.m.t delete $console_cr end
                                $w.m.t insert end "\n"
                                $w.m.t insert end [string range $buf $c $cr]
                                set c $cr
@@ -120,66 +123,54 @@ proc console_read {w fd after} {
                } else {
                        set ok 1
                }
-               uplevel #0 $after $w $ok
+               if {$after ne {}} {
+                       uplevel #0 $after $ok
+               } else {
+                       done $this $ok
+               }
                return
        }
        fconfigure $fd -blocking 0
 }
 
-proc console_chain {cmdlist w {ok 1}} {
+method chain {cmdlist {ok 1}} {
        if {$ok} {
                if {[llength $cmdlist] == 0} {
-                       console_done $w $ok
+                       done $this $ok
                        return
                }
 
                set cmd [lindex $cmdlist 0]
                set cmdlist [lrange $cmdlist 1 end]
 
-               if {[lindex $cmd 0] eq {console_exec}} {
-                       console_exec $w \
-                               [lindex $cmd 1] \
-                               [list console_chain $cmdlist]
+               if {[lindex $cmd 0] eq {exec}} {
+                       exec $this \
+                               [lrange $cmd 1 end] \
+                               [cb chain $cmdlist]
                } else {
-                       uplevel #0 $cmd $cmdlist $w $ok
+                       uplevel #0 $cmd [cb chain $cmdlist]
                }
        } else {
-               console_done $w $ok
+               done $this $ok
        }
 }
 
-proc console_done {args} {
-       global console_cr console_data
-
-       switch -- [llength $args] {
-       2 {
-               set w [lindex $args 0]
-               set ok [lindex $args 1]
-       }
-       3 {
-               set w [lindex $args 1]
-               set ok [lindex $args 2]
-       }
-       default {
-               error "wrong number of args: console_done ?ignored? w ok"
-       }
-       }
-
+method done {ok} {
        if {$ok} {
-               if {[winfo exists $w]} {
+               if {[winfo exists $w.m.s]} {
                        $w.m.s conf -background green -text {Success}
                        $w.ok conf -state normal
                        focus $w.ok
                }
        } else {
-               if {![winfo exists $w]} {
-                       console_init $w
+               if {![winfo exists $w.m.s]} {
+                       _init $this
                }
                $w.m.s conf -background red -text {Error: Command Failed}
                $w.ok conf -state normal
                focus $w.ok
        }
+       delete_this
+}
 
-       array unset console_cr $w
-       array unset console_data $w
 }