combine-diff: better hunk splitting.

diff --git a/git-push.sh b/git-push.sh
index 136093bf138f57d45385c0d71344b4cd85c472d6..706db9933e7a3d418a0bc77a743695464901b800 100755 (executable)
--- a/git-push.sh
+++ b/git-push.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-USAGE='[--all] [--force] <repository> [<refspec>...]'
+USAGE='[--all] [--tags] [--force] <repository> [<refspec>...]'
 . git-sh-setup
 
 # Parse out parameters and then stop at remote, so that we can
@@ -36,32 +36,30 @@ case "$#" in
        echo "Where would you want to push today?"
         usage ;;
 esac
-if test ",$has_all,$do_tags," = ",--all,yes,"
-then
-       do_tags=
-fi
 
 . git-parse-remote
 remote=$(get_remote_url "$@")
-case "$has_all" in
---all) set x ;;
-'')    set x $(get_remote_refs_for_push "$@") ;;
-esac
-shift
 
-case "$do_tags" in
-yes)
-       set "$@" $(cd "$GIT_DIR/refs" && find tags -type f -print) ;;
+case "$has_all" in
+--all)
+       set x ;;
+'')
+       case "$do_tags,$#" in
+       yes,1)
+               set x $(cd "$GIT_DIR/refs" && find tags -type f -print) ;;
+       yes,*)
+               set x $(cd "$GIT_DIR/refs" && find tags -type f -print) \
+                   $(get_remote_refs_for_push "$@") ;;
+       ,*)
+               set x $(get_remote_refs_for_push "$@") ;;
+       esac
 esac
 
-# Now we have explicit refs from the command line or from remotes/
-# shorthand, or --tags.  Falling back on the current branch if we still
-# do not have any may be an alternative, but prevent mistakes for now.
+shift ;# away the initial 'x'
 
-case "$#,$has_all" in
-0,)
-       die "No refs given to be pushed." ;;
-esac
+# $# is now 0 if there was no explicit refspec on the command line
+# and there was no defalt refspec to push from remotes/ file.
+# we will let git-send-pack to do its "matching refs" thing.
 
 case "$remote" in
 git://*)