Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
commit.c: use the generic "sha1_pos" function for lookup
author
Dmitry S. Dolzhenko
<dmitrys.dolzhenko@yandex.ru>
Wed, 26 Feb 2014 18:49:22 +0000
(22:49 +0400)
committer
Junio C Hamano
<gitster@pobox.com>
Thu, 27 Feb 2014 18:55:27 +0000
(10:55 -0800)
Refactor binary search in "commit_graft_pos" function: use
generic "sha1_pos" function.
Signed-off-by: Dmitry S. Dolzhenko <dmitrys.dolzhenko@yandex.ru>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
commit.c
patch
|
blob
|
history
raw
|
patch
|
inline
| side by side (parent:
5f95c9f
)
diff --git
a/commit.c
b/commit.c
index 6bf4fe00d4b0365eca75fd9988852650660b6884..6ceee6acbc0a6c3c44d38e91c9f138a89fb3d075 100644
(file)
--- a/
commit.c
+++ b/
commit.c
@@
-10,6
+10,7
@@
#include "mergesort.h"
#include "commit-slab.h"
#include "prio-queue.h"
#include "mergesort.h"
#include "commit-slab.h"
#include "prio-queue.h"
+#include "sha1-lookup.h"
static struct commit_extra_header *read_commit_extra_header_lines(const char *buf, size_t len, const char **);
static struct commit_extra_header *read_commit_extra_header_lines(const char *buf, size_t len, const char **);
@@
-114,23
+115,16
@@
static unsigned long parse_commit_date(const char *buf, const char *tail)
static struct commit_graft **commit_graft;
static int commit_graft_alloc, commit_graft_nr;
static struct commit_graft **commit_graft;
static int commit_graft_alloc, commit_graft_nr;
+static const unsigned char *commit_graft_sha1_access(size_t index, void *table)
+{
+ struct commit_graft **commit_graft_table = table;
+ return commit_graft_table[index]->sha1;
+}
+
static int commit_graft_pos(const unsigned char *sha1)
{
static int commit_graft_pos(const unsigned char *sha1)
{
- int lo, hi;
- lo = 0;
- hi = commit_graft_nr;
- while (lo < hi) {
- int mi = (lo + hi) / 2;
- struct commit_graft *graft = commit_graft[mi];
- int cmp = hashcmp(sha1, graft->sha1);
- if (!cmp)
- return mi;
- if (cmp < 0)
- hi = mi;
- else
- lo = mi + 1;
- }
- return -lo - 1;
+ return sha1_pos(sha1, commit_graft, commit_graft_nr,
+ commit_graft_sha1_access);
}
int register_commit_graft(struct commit_graft *graft, int ignore_dups)
}
int register_commit_graft(struct commit_graft *graft, int ignore_dups)