test-lib: simplify '--option=value' parsing

To get the 'value' from '--option=value', test-lib.sh parses said
option running 'expr' with a regexp.  This involves a subshell, an
external process, and a lot of non-alphanumeric characters in the
regexp.

Use a much simpler POSIX-defined shell parameter expansion instead to
do the same.

Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/test-lib.sh b/t/test-lib.sh
index 0b47eb6bb299492d31111c94557c216bb3f32c7f..79afa8748eec6c8a9dece4db58c6efcfb343f2ae 100644 (file)
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -202,13 +202,13 @@ do
                }
                run_list=$1; shift ;;
        --run=*)
                }
                run_list=$1; shift ;;
        --run=*)

-               run_list=$(expr "z$1" : 'z[^=]*=\(.*\)'); shift ;;
+               run_list=${1#--*=}; shift ;;

        -h|--h|--he|--hel|--help)
                help=t; shift ;;
        -v|--v|--ve|--ver|--verb|--verbo|--verbos|--verbose)
                verbose=t; shift ;;
        --verbose-only=*)
        -h|--h|--he|--hel|--help)
                help=t; shift ;;
        -v|--v|--ve|--ver|--verb|--verbo|--verbos|--verbose)
                verbose=t; shift ;;
        --verbose-only=*)

-               verbose_only=$(expr "z$1" : 'z[^=]*=\(.*\)')
+               verbose_only=${1#--*=}

                shift ;;
        -q|--q|--qu|--qui|--quie|--quiet)
                # Ignore --quiet under a TAP::Harness. Saying how many tests
                shift ;;
        -q|--q|--qu|--qui|--quie|--quiet)
                # Ignore --quiet under a TAP::Harness. Saying how many tests


@@ -222,15 +222,15 @@ do
                valgrind=memcheck
                shift ;;
        --valgrind=*)
                valgrind=memcheck
                shift ;;
        --valgrind=*)

-               valgrind=$(expr "z$1" : 'z[^=]*=\(.*\)')
+               valgrind=${1#--*=}

                shift ;;
        --valgrind-only=*)
                shift ;;
        --valgrind-only=*)

-               valgrind_only=$(expr "z$1" : 'z[^=]*=\(.*\)')
+               valgrind_only=${1#--*=}

                shift ;;
        --tee)
                shift ;; # was handled already
        --root=*)
                shift ;;
        --tee)
                shift ;; # was handled already
        --root=*)

-               root=$(expr "z$1" : 'z[^=]*=\(.*\)')
+               root=${1#--*=}

                shift ;;
        --chain-lint)
                GIT_TEST_CHAIN_LINT=1
                shift ;;
        --chain-lint)
                GIT_TEST_CHAIN_LINT=1