merge-base: do not leak commit list

Signed-off-by: Junio C Hamano <junkio@cox.net>

diff --git a/commit.c b/commit.c
index 9ce45cec25d80bab22ba7267a6e2a58318ac3eeb..496d37aa020871aed111002c2be0380366a70baa 100644 (file)
--- a/commit.c
+++ b/commit.c
@@ -1012,7 +1012,7 @@ void sort_in_topological_order_fn(struct commit_list ** list, int lifo,
        free(nodes);
 }
 
        free(nodes);
 }
 

-/* merge-rebase stuff */
+/* merge-base stuff */

 
 /* bits #0..15 in revision.h */
 #define PARENT1                (1u<<16)
 
 /* bits #0..15 in revision.h */
 #define PARENT1                (1u<<16)


@@ -1020,6 +1020,8 @@ void sort_in_topological_order_fn(struct commit_list ** list, int lifo,
 #define STALE          (1u<<18)
 #define RESULT         (1u<<19)
 
 #define STALE          (1u<<18)
 #define RESULT         (1u<<19)
 

+static const unsigned all_flags = (PARENT1 | PARENT2 | STALE | RESULT);
+

 static struct commit *interesting(struct commit_list *list)
 {
        while (list) {
 static struct commit *interesting(struct commit_list *list)
 {
        while (list) {


@@ -1084,6 +1086,7 @@ static struct commit_list *merge_bases(struct commit *one, struct commit *two)
        }
 
        /* Clean up the result to remove stale ones */
        }
 
        /* Clean up the result to remove stale ones */

+       free_commit_list(list);

        list = result; result = NULL;
        while (list) {
                struct commit_list *n = list->next;
        list = result; result = NULL;
        while (list) {
                struct commit_list *n = list->next;


@@ -1099,7 +1102,6 @@ struct commit_list *get_merge_bases(struct commit *one,
                                    struct commit *two,
                                     int cleanup)
 {
                                    struct commit *two,
                                     int cleanup)
 {

-       const unsigned all_flags = (PARENT1 | PARENT2 | STALE | RESULT);

        struct commit_list *list;
        struct commit **rslt;
        struct commit_list *result;
        struct commit_list *list;
        struct commit **rslt;
        struct commit_list *result;