git p4 test: wildcards are supported

Since 9d57c4a (git p4: implement view spec wildcards with "p4
where", 2013-08-30), all the wildcard types should be supported.
Change must-fail tests to mark that they now pass.

Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t9809-git-p4-client-view.sh b/t/t9809-git-p4-client-view.sh
index 77f63492d90e61500e6665ba447fbbad7a8c7b3b..23a827fa77d0a5d527cef29a15a205ee14d68e27 100755 (executable)
--- a/t/t9809-git-p4-client-view.sh
+++ b/t/t9809-git-p4-client-view.sh
@@ -76,28 +76,28 @@ test_expect_success 'init depot' '
 '
 
 # double % for printf
 '
 
 # double % for printf

-test_expect_success 'unsupported view wildcard %%n' '
+test_expect_success 'view wildcard %%n' '

        client_view "//depot/%%%%1/sub/... //client/sub/%%%%1/..." &&
        test_when_finished cleanup_git &&
        client_view "//depot/%%%%1/sub/... //client/sub/%%%%1/..." &&
        test_when_finished cleanup_git &&

-       test_must_fail git p4 clone --use-client-spec --dest="$git" //depot
+       git p4 clone --use-client-spec --dest="$git" //depot

 '
 
 '
 

-test_expect_success 'unsupported view wildcard *' '
+test_expect_success 'view wildcard *' '

        client_view "//depot/*/bar/... //client/*/bar/..." &&
        test_when_finished cleanup_git &&
        client_view "//depot/*/bar/... //client/*/bar/..." &&
        test_when_finished cleanup_git &&

-       test_must_fail git p4 clone --use-client-spec --dest="$git" //depot
+       git p4 clone --use-client-spec --dest="$git" //depot

 '
 
 '
 

-test_expect_success 'wildcard ... only supported at end of spec 1' '
+test_expect_success 'wildcard ... in the middle' '

        client_view "//depot/.../file11 //client/.../file11" &&
        test_when_finished cleanup_git &&
        client_view "//depot/.../file11 //client/.../file11" &&
        test_when_finished cleanup_git &&

-       test_must_fail git p4 clone --use-client-spec --dest="$git" //depot
+       git p4 clone --use-client-spec --dest="$git" //depot

 '
 
 '
 

-test_expect_success 'wildcard ... only supported at end of spec 2' '
+test_expect_success 'wildcard ... in the middle and at the end' '

        client_view "//depot/.../a/... //client/.../a/..." &&
        test_when_finished cleanup_git &&
        client_view "//depot/.../a/... //client/.../a/..." &&
        test_when_finished cleanup_git &&

-       test_must_fail git p4 clone --use-client-spec --dest="$git" //depot
+       git p4 clone --use-client-spec --dest="$git" //depot

 '
 
 test_expect_success 'basic map' '
 '
 
 test_expect_success 'basic map' '