Fix http-fetch

With the latest changes in fetch.c, http-fetch crashed accessing
write_ref[i], where write_ref was NULL.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>

diff --git a/fetch.c b/fetch.c
index 2151c7b78c34f06f38f538f155169a0501c2ff54..aeb6bf2639cc75b6f738348bcc267179a8a0da65 100644 (file)
--- a/fetch.c
+++ b/fetch.c
@@ -245,7 +245,7 @@ void pull_targets_free(int targets, char **target, const char **write_ref)
 {
        while (targets--) {
                free(target[targets]);
 {
        while (targets--) {
                free(target[targets]);

-               if (write_ref[targets])
+               if (write_ref && write_ref[targets])

                        free((char *) write_ref[targets]);
        }
 }
                        free((char *) write_ref[targets]);
        }
 }


@@ -263,7 +263,7 @@ int pull(int targets, char **target, const char **write_ref,
        track_object_refs = 0;
 
        for (i = 0; i < targets; i++) {
        track_object_refs = 0;
 
        for (i = 0; i < targets; i++) {

-               if (!write_ref[i])
+               if (!write_ref || !write_ref[i])

                        continue;
 
                lock[i] = lock_ref_sha1(write_ref[i], NULL, 0);
                        continue;
 
                lock[i] = lock_ref_sha1(write_ref[i], NULL, 0);


@@ -295,7 +295,7 @@ int pull(int targets, char **target, const char **write_ref,
                msg = NULL;
        }
        for (i = 0; i < targets; i++) {
                msg = NULL;
        }
        for (i = 0; i < targets; i++) {

-               if (!write_ref[i])
+               if (!write_ref || !write_ref[i])

                        continue;
                ret = write_ref_sha1(lock[i], &sha1[20 * i], msg ? msg : "fetch (unknown)");
                lock[i] = NULL;
                        continue;
                ret = write_ref_sha1(lock[i], &sha1[20 * i], msg ? msg : "fetch (unknown)");
                lock[i] = NULL;