clone: respect user supplied origin name when setting up partial clone

Signed-off-by: Xin Li <delphij@google.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/clone.c b/builtin/clone.c
index 85b0d3155de0d9ee9257ac44acc699c004022836..356bae5ed72d2e510da08d8089fbdda607ba0e9f 100644 (file)
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -1220,7 +1220,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
                        remote_head_points_at, &branch_top);
 
        if (filter_options.choice)
                        remote_head_points_at, &branch_top);
 
        if (filter_options.choice)

-               partial_clone_register("origin", &filter_options);
+               partial_clone_register(option_origin, &filter_options);

 
        if (is_local)
                clone_local(path, git_dir);
 
        if (is_local)
                clone_local(path, git_dir);

diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
index de9d99cf88a5b72a3aa6e190124dff36e67818b6..37d76808d4a74b101f0606fc7a114fed6a8afa91 100755 (executable)
--- a/t/t5601-clone.sh
+++ b/t/t5601-clone.sh
@@ -630,9 +630,8 @@ test_expect_success CASE_INSENSITIVE_FS 'colliding file detection' '
        test_i18ngrep "the following paths have collided" icasefs/warning
 '
 
        test_i18ngrep "the following paths have collided" icasefs/warning
 '
 

-partial_clone () {
+partial_clone_server () {

               SERVER="$1" &&
               SERVER="$1" &&

-              URL="$2" &&

 
        rm -rf "$SERVER" client &&
        test_create_repo "$SERVER" &&
 
        rm -rf "$SERVER" client &&
        test_create_repo "$SERVER" &&


@@ -642,8 +641,14 @@ partial_clone () {
        test_commit -C "$SERVER" two &&
        HASH2=$(git hash-object "$SERVER/two.t") &&
        test_config -C "$SERVER" uploadpack.allowfilter 1 &&
        test_commit -C "$SERVER" two &&
        HASH2=$(git hash-object "$SERVER/two.t") &&
        test_config -C "$SERVER" uploadpack.allowfilter 1 &&

-       test_config -C "$SERVER" uploadpack.allowanysha1inwant 1 &&
+       test_config -C "$SERVER" uploadpack.allowanysha1inwant 1
+}

 
 

+partial_clone () {
+              SERVER="$1" &&
+              URL="$2" &&
+
+       partial_clone_server "${SERVER}" &&

        git clone --filter=blob:limit=0 "$URL" client &&
 
        git -C client fsck &&
        git clone --filter=blob:limit=0 "$URL" client &&
 
        git -C client fsck &&


@@ -660,6 +665,11 @@ test_expect_success 'partial clone' '
        partial_clone server "file://$(pwd)/server"
 '
 
        partial_clone server "file://$(pwd)/server"
 '
 

+test_expect_success 'partial clone with -o' '
+       partial_clone_server server &&
+       git clone -o blah --filter=blob:limit=0 "file://$(pwd)/server" client
+'
+

 test_expect_success 'partial clone: warn if server does not support object filtering' '
        rm -rf server client &&
        test_create_repo server &&
 test_expect_success 'partial clone: warn if server does not support object filtering' '
        rm -rf server client &&
        test_create_repo server &&