Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
git-svn: do not let Git.pm warn if we prematurely close pipes
author
Eric Wong
<normalperson@yhbt.net>
Thu, 1 Feb 2007 21:12:26 +0000
(13:12 -0800)
committer
Junio C Hamano
<junkio@cox.net>
Fri, 2 Feb 2007 05:51:36 +0000
(21:51 -0800)
This mainly quiets down warnings when running git svn log.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
git-svn.perl
patch
|
blob
|
history
raw
|
patch
|
inline
| side by side (parent:
1e5db30
)
diff --git
a/git-svn.perl
b/git-svn.perl
index 68156fc8a5d3e886fae61dae531f647e35b4899d..8ebaae9ff8865ab638f7a2db8c64f2d22f227470 100755
(executable)
--- a/
git-svn.perl
+++ b/
git-svn.perl
@@
-681,7
+681,7
@@
sub show_log {
process_commit($_, $r_min, $r_max) foreach reverse @k;
}
out:
process_commit($_, $r_min, $r_max) foreach reverse @k;
}
out:
-
eval { command_close_pipe($log) }
;
+
close $log
;
print '-' x72,"\n" unless $_incremental || $_oneline;
}
print '-' x72,"\n" unless $_incremental || $_oneline;
}
@@
-1475,7
+1475,7
@@
sub map_tree_joins {
$seen{$commit} = 1;
}
}
$seen{$commit} = 1;
}
}
-
eval { command_close_pipe($pipe) }
;
+
close $pipe
;
}
}
}
}
@@
-1669,7
+1669,7
@@
sub write_grafts {
last unless /^\S/;
}
}
last unless /^\S/;
}
}
-
eval { command_close_pipe($ch) }
; # breaking the pipe
+
close $ch
; # breaking the pipe
# if real parents are the only ones in the grafts, drop it
next if join(' ',sort keys %$p) eq join(' ',sort keys %x);
# if real parents are the only ones in the grafts, drop it
next if join(' ',sort keys %$p) eq join(' ',sort keys %x);
@@
-1766,7
+1766,7
@@
sub get_commit_time {
} elsif ($tz =~ s/^\-//) {
$s -= tz_to_s_offset($tz);
}
} elsif ($tz =~ s/^\-//) {
$s -= tz_to_s_offset($tz);
}
-
eval { command_close_pipe($fh) }
;
+
close $fh
;
return $s;
}
die "Can't get commit time for commit: $cmt\n";
return $s;
}
die "Can't get commit time for commit: $cmt\n";
@@
-2846,7
+2846,7
@@
sub rmdirs {
delete $rm->{join '/', @dn};
}
unless (%$rm) {
delete $rm->{join '/', @dn};
}
unless (%$rm) {
-
eval { command_close_pipe($fh) }
;
+
close $fh
;
return;
}
}
return;
}
}