Refuse deleting the current branch via push

This makes git-push refuse deleting the current branch by default.

Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin-receive-pack.c b/builtin-receive-pack.c
index b8b69dde48e4d3a472270c04ff6fc2f3d1594f54..db12b813acbe9bade2b854b3a94fed13f6210499 100644 (file)
--- a/builtin-receive-pack.c
+++ b/builtin-receive-pack.c
@@ -241,30 +241,24 @@ static void refuse_unconfigured_deny(void)
                error("%s", refuse_unconfigured_deny_msg[i]);
 }
 
                error("%s", refuse_unconfigured_deny_msg[i]);
 }
 

-static char *warn_unconfigured_deny_delete_current_msg[] = {
-       "Deleting the current branch can cause confusion by making the next",
-       "'git clone' not check out any file.",
+static char *refuse_unconfigured_deny_delete_current_msg[] = {
+       "By default, deleting the current branch is denied, because the next",
+       "'git clone' won't result in any file checked out, causing confusion.",

        "",
        "You can set 'receive.denyDeleteCurrent' configuration variable to",
        "",
        "You can set 'receive.denyDeleteCurrent' configuration variable to",

-       "'refuse' in the remote repository to disallow deleting the current",
-       "branch.",
+       "'warn' or 'ignore' in the remote repository to allow deleting the",
+       "current branch, with or without a warning message.",

        "",
        "",

-       "You can set it to 'ignore' to allow such a delete without a warning.",
-       "",
-       "To make this warning message less loud, you can set it to 'warn'.",
-       "",
-       "Note that the default will change in a future version of git",
-       "to refuse deleting the current branch unless you have the",
-       "configuration variable set to either 'ignore' or 'warn'."
+       "To squelch this message, you can set it to 'refuse'."

 };
 
 };
 

-static void warn_unconfigured_deny_delete_current(void)
+static void refuse_unconfigured_deny_delete_current(void)

 {
        int i;
        for (i = 0;
 {
        int i;
        for (i = 0;

-            i < ARRAY_SIZE(warn_unconfigured_deny_delete_current_msg);
+            i < ARRAY_SIZE(refuse_unconfigured_deny_delete_current_msg);

             i++)
             i++)

-               warning("%s", warn_unconfigured_deny_delete_current_msg[i]);
+               error("%s", refuse_unconfigured_deny_delete_current_msg[i]);

 }
 
 static const char *update(struct command *cmd)
 }
 
 static const char *update(struct command *cmd)


@@ -313,12 +307,12 @@ static const char *update(struct command *cmd)
                        case DENY_IGNORE:
                                break;
                        case DENY_WARN:
                        case DENY_IGNORE:
                                break;
                        case DENY_WARN:

-                       case DENY_UNCONFIGURED:
-                               if (deny_delete_current == DENY_UNCONFIGURED)
-                                       warn_unconfigured_deny_delete_current();

                                warning("deleting the current branch");
                                break;
                        case DENY_REFUSE:
                                warning("deleting the current branch");
                                break;
                        case DENY_REFUSE:

+                       case DENY_UNCONFIGURED:
+                               if (deny_delete_current == DENY_UNCONFIGURED)
+                                       refuse_unconfigured_deny_delete_current();

                                error("refusing to delete the current branch: %s", name);
                                return "deletion of the current branch prohibited";
                        }
                                error("refusing to delete the current branch: %s", name);
                                return "deletion of the current branch prohibited";
                        }

diff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh
index 8463332cb8038307e2dfffa9e43cf92d331eef07..c718253673ec8b3baf635c4dc0b05fe127c6f4cd 100755 (executable)
--- a/t/t5400-send-pack.sh
+++ b/t/t5400-send-pack.sh
@@ -191,16 +191,11 @@ test_expect_success 'pushing wildcard refspecs respects forcing' '
        test "$parent_head" = "$child_head"
 '
 
        test "$parent_head" = "$child_head"
 '
 

-test_expect_success 'warn pushing to delete current branch' '
+test_expect_success 'deny pushing to delete current branch' '

        rewound_push_setup &&
        (
            cd child &&
        rewound_push_setup &&
        (
            cd child &&

-           git send-pack ../parent :refs/heads/master 2>errs
-       ) &&
-       grep "warning: to refuse deleting" child/errs &&
-       (
-               cd parent &&
-               test_must_fail git rev-parse --verify master
+           test_must_fail git send-pack ../parent :refs/heads/master 2>errs

        )
 '
 
        )
 '