Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
gitweb: Quote hash keys, and do not use barewords keys
author
Jakub Narebski
<jnareb@gmail.com>
Sun, 1 Apr 2007 20:22:21 +0000
(22:22 +0200)
committer
Junio C Hamano
<junkio@cox.net>
Wed, 4 Apr 2007 09:37:35 +0000
(
02:37
-0700)
Ensure that in all references to an element of a hash, the
key is singlequoted, instead of using bareword: use $hash{'key'}
instead of $hash{key}
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
gitweb/gitweb.perl
patch
|
blob
|
history
raw
|
patch
|
inline
| side by side (parent:
a23f0a7
)
diff --git
a/gitweb/gitweb.perl
b/gitweb/gitweb.perl
index 8c3123ed06233fd5d463f1494850c0f5dbbdda49..ea491562c80fbb8147746bd0dd711529555780ee 100755
(executable)
--- a/
gitweb/gitweb.perl
+++ b/
gitweb/gitweb.perl
@@
-19,7
+19,7
@@
binmode STDOUT, ':utf8';
BEGIN {
binmode STDOUT, ':utf8';
BEGIN {
- CGI->compile() if $ENV{
MOD_PERL
};
+ CGI->compile() if $ENV{
'MOD_PERL'
};
}
our $cgi = new CGI;
}
our $cgi = new CGI;
@@
-1870,16
+1870,16
@@
sub git_print_page_nav {
my %arg = map { $_ => {action=>$_} } @navs;
if (defined $head) {
for (qw(commit commitdiff)) {
my %arg = map { $_ => {action=>$_} } @navs;
if (defined $head) {
for (qw(commit commitdiff)) {
- $arg{$_}{
hash
} = $head;
+ $arg{$_}{
'hash'
} = $head;
}
if ($current =~ m/^(tree | log | shortlog | commit | commitdiff | search)$/x) {
for (qw(shortlog log)) {
}
if ($current =~ m/^(tree | log | shortlog | commit | commitdiff | search)$/x) {
for (qw(shortlog log)) {
- $arg{$_}{
hash
} = $head;
+ $arg{$_}{
'hash'
} = $head;
}
}
}
}
}
}
- $arg{
tree}{hash
} = $treehead if defined $treehead;
- $arg{
tree}{hash_base
} = $treebase if defined $treebase;
+ $arg{
'tree'}{'hash'
} = $treehead if defined $treehead;
+ $arg{
'tree'}{'hash_base'
} = $treebase if defined $treebase;
print "<div class=\"page_nav\">\n" .
(join " | ",
print "<div class=\"page_nav\">\n" .
(join " | ",
@@
-1927,9
+1927,9
@@
sub git_print_header_div {
my ($action, $title, $hash, $hash_base) = @_;
my %args = ();
my ($action, $title, $hash, $hash_base) = @_;
my %args = ();
- $args{
action
} = $action;
- $args{
hash
} = $hash if $hash;
- $args{
hash_base
} = $hash_base if $hash_base;
+ $args{
'action'
} = $action;
+ $args{
'hash'
} = $hash if $hash;
+ $args{
'hash_base'
} = $hash_base if $hash_base;
print "<div class=\"header\">\n" .
$cgi->a({-href => href(%args), -class => "title"},
print "<div class=\"header\">\n" .
$cgi->a({-href => href(%args), -class => "title"},