http_get_file: style fixes

Besides being ugly, the extra parentheses are idiomatic for
suppressing compiler warnings when we are assigning within a
conditional. We aren't doing that here, and they just
confuse the reader.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>

diff --git a/http.c b/http.c
index 2d086aedfac9a8ea384c53f3b1963149b880ed31..9b1015881a97637d00aa262fb63dfd0cee3d561f 100644 (file)
--- a/http.c
+++ b/http.c
@@ -941,7 +941,7 @@ static int http_get_file(const char *url, const char *filename, int options)
 
        strbuf_addf(&tmpfile, "%s.temp", filename);
        result = fopen(tmpfile.buf, "a");
 
        strbuf_addf(&tmpfile, "%s.temp", filename);
        result = fopen(tmpfile.buf, "a");

-       if (! result) {
+       if (!result) {

                error("Unable to open local file %s", tmpfile.buf);
                ret = HTTP_ERROR;
                goto cleanup;
                error("Unable to open local file %s", tmpfile.buf);
                ret = HTTP_ERROR;
                goto cleanup;


@@ -950,7 +950,7 @@ static int http_get_file(const char *url, const char *filename, int options)
        ret = http_request_reauth(url, NULL, result, HTTP_REQUEST_FILE, options);
        fclose(result);
 
        ret = http_request_reauth(url, NULL, result, HTTP_REQUEST_FILE, options);
        fclose(result);
 

-       if ((ret == HTTP_OK) && move_temp_to_file(tmpfile.buf, filename))
+       if (ret == HTTP_OK && move_temp_to_file(tmpfile.buf, filename))

                ret = HTTP_ERROR;
 cleanup:
        strbuf_release(&tmpfile);
                ret = HTTP_ERROR;
 cleanup:
        strbuf_release(&tmpfile);