name-hash.c: remove cache entries instead of marking them CE_UNHASHED

The new hashmap implementation supports remove, so really remove unused
cache entries from the name hashmap instead of just marking them.

The CE_UNHASHED flag and CE_STATE_MASK are no longer needed.

Keep the CE_HASHED flag to prevent adding entries twice.

Signed-off-by: Karsten Blees <blees@dcon.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/cache.h b/cache.h
index 85210b1bd271b4799e54b7e5265dc217511a9445..1f11e24cd09de27f9155f6259d7ccbcac363bcc9 100644 (file)
--- a/cache.h
+++ b/cache.h
@@ -160,7 +160,6 @@ struct cache_entry {
 #define CE_ADDED             (1 << 19)
 
 #define CE_HASHED            (1 << 20)
 #define CE_ADDED             (1 << 19)
 
 #define CE_HASHED            (1 << 20)

-#define CE_UNHASHED          (1 << 21)

 #define CE_WT_REMOVE         (1 << 22) /* remove in work directory */
 #define CE_CONFLICTED        (1 << 23)
 
 #define CE_WT_REMOVE         (1 << 22) /* remove in work directory */
 #define CE_CONFLICTED        (1 << 23)
 


@@ -196,11 +195,10 @@ struct pathspec;
  * Copy the sha1 and stat state of a cache entry from one to
  * another. But we never change the name, or the hash state!
  */
  * Copy the sha1 and stat state of a cache entry from one to
  * another. But we never change the name, or the hash state!
  */

-#define CE_STATE_MASK (CE_HASHED | CE_UNHASHED)

 static inline void copy_cache_entry(struct cache_entry *dst,
                                    const struct cache_entry *src)
 {
 static inline void copy_cache_entry(struct cache_entry *dst,
                                    const struct cache_entry *src)
 {

-       unsigned int state = dst->ce_flags & CE_STATE_MASK;
+       unsigned int state = dst->ce_flags & CE_HASHED;

 
        /* Don't copy hash chain and name */
        memcpy(&dst->ce_stat_data, &src->ce_stat_data,
 
        /* Don't copy hash chain and name */
        memcpy(&dst->ce_stat_data, &src->ce_stat_data,


@@ -208,7 +206,7 @@ static inline void copy_cache_entry(struct cache_entry *dst,
                        offsetof(struct cache_entry, ce_stat_data));
 
        /* Restore the hash state */
                        offsetof(struct cache_entry, ce_stat_data));
 
        /* Restore the hash state */

-       dst->ce_flags = (dst->ce_flags & ~CE_STATE_MASK) | state;
+       dst->ce_flags = (dst->ce_flags & ~CE_HASHED) | state;

 }
 
 static inline unsigned create_ce_flags(unsigned stage)
 }
 
 static inline unsigned create_ce_flags(unsigned stage)

diff --git a/name-hash.c b/name-hash.c
index 488eccf2f986f00380c03011090b9945d25048e7..9a3bd3f9a629e2cd37dfb1277ccb9ae190c947c8 100644 (file)
--- a/name-hash.c
+++ b/name-hash.c
@@ -106,17 +106,29 @@ static void hash_index_entry(struct index_state *istate, struct cache_entry *ce)
        hashmap_entry_init(ce, memihash(ce->name, ce_namelen(ce)));
        hashmap_add(&istate->name_hash, ce);
 
        hashmap_entry_init(ce, memihash(ce->name, ce_namelen(ce)));
        hashmap_add(&istate->name_hash, ce);
 

-       if (ignore_case && !(ce->ce_flags & CE_UNHASHED))
+       if (ignore_case)

                add_dir_entry(istate, ce);
 }
 
                add_dir_entry(istate, ce);
 }
 

+static int cache_entry_cmp(const struct cache_entry *ce1,
+               const struct cache_entry *ce2, const void *remove)
+{
+       /*
+        * For remove_name_hash, find the exact entry (pointer equality); for
+        * index_name_exists, find all entries with matching hash code and
+        * decide whether the entry matches in same_name.
+        */
+       return remove ? !(ce1 == ce2) : 0;
+}
+

 static void lazy_init_name_hash(struct index_state *istate)
 {
        int nr;
 
        if (istate->name_hash_initialized)
                return;
 static void lazy_init_name_hash(struct index_state *istate)
 {
        int nr;
 
        if (istate->name_hash_initialized)
                return;

-       hashmap_init(&istate->name_hash, NULL, istate->cache_nr);
+       hashmap_init(&istate->name_hash, (hashmap_cmp_fn) cache_entry_cmp,
+                       istate->cache_nr);

        hashmap_init(&istate->dir_hash, (hashmap_cmp_fn) dir_entry_cmp, 0);
        for (nr = 0; nr < istate->cache_nr; nr++)
                hash_index_entry(istate, istate->cache[nr]);
        hashmap_init(&istate->dir_hash, (hashmap_cmp_fn) dir_entry_cmp, 0);
        for (nr = 0; nr < istate->cache_nr; nr++)
                hash_index_entry(istate, istate->cache[nr]);


@@ -125,31 +137,19 @@ static void lazy_init_name_hash(struct index_state *istate)
 
 void add_name_hash(struct index_state *istate, struct cache_entry *ce)
 {
 
 void add_name_hash(struct index_state *istate, struct cache_entry *ce)
 {

-       /* if already hashed, add reference to directory entries */
-       if (ignore_case && (ce->ce_flags & CE_STATE_MASK) == CE_STATE_MASK)
-               add_dir_entry(istate, ce);
-
-       ce->ce_flags &= ~CE_UNHASHED;

        if (istate->name_hash_initialized)
                hash_index_entry(istate, ce);
 }
 
        if (istate->name_hash_initialized)
                hash_index_entry(istate, ce);
 }
 

-/*
- * We don't actually *remove* it, we can just mark it invalid so that
- * we won't find it in lookups.
- *
- * Not only would we have to search the lists (simple enough), but
- * we'd also have to rehash other hash buckets in case this makes the
- * hash bucket empty (common). So it's much better to just mark
- * it.
- */

 void remove_name_hash(struct index_state *istate, struct cache_entry *ce)
 {
 void remove_name_hash(struct index_state *istate, struct cache_entry *ce)
 {

-       /* if already hashed, release reference to directory entries */
-       if (ignore_case && (ce->ce_flags & CE_STATE_MASK) == CE_HASHED)
-               remove_dir_entry(istate, ce);
+       if (!istate->name_hash_initialized || !(ce->ce_flags & CE_HASHED))
+               return;
+       ce->ce_flags &= ~CE_HASHED;
+       hashmap_remove(&istate->name_hash, ce, ce);

 
 

-       ce->ce_flags |= CE_UNHASHED;
+       if (ignore_case)
+               remove_dir_entry(istate, ce);

 }
 
 static int slow_same_name(const char *name1, int len1, const char *name2, int len2)
 }
 
 static int slow_same_name(const char *name1, int len1, const char *name2, int len2)


@@ -220,10 +220,8 @@ struct cache_entry *index_file_exists(struct index_state *istate, const char *na
        hashmap_entry_init(&key, memihash(name, namelen));
        ce = hashmap_get(&istate->name_hash, &key, NULL);
        while (ce) {
        hashmap_entry_init(&key, memihash(name, namelen));
        ce = hashmap_get(&istate->name_hash, &key, NULL);
        while (ce) {

-               if (!(ce->ce_flags & CE_UNHASHED)) {
-                       if (same_name(ce, name, namelen, icase))
-                               return ce;
-               }
+               if (same_name(ce, name, namelen, icase))
+                       return ce;

                ce = hashmap_get_next(&istate->name_hash, ce);
        }
        return NULL;
                ce = hashmap_get_next(&istate->name_hash, ce);
        }
        return NULL;

diff --git a/read-cache.c b/read-cache.c
index 33dd676ccbbd24e0bace49347f1f5d81b5099bcc..00af9addd90d9b44f9134d50708548896deb0e2f 100644 (file)
--- a/read-cache.c
+++ b/read-cache.c
@@ -58,7 +58,7 @@ void rename_index_entry_at(struct index_state *istate, int nr, const char *new_n
 
        new = xmalloc(cache_entry_size(namelen));
        copy_cache_entry(new, old);
 
        new = xmalloc(cache_entry_size(namelen));
        copy_cache_entry(new, old);

-       new->ce_flags &= ~CE_STATE_MASK;
+       new->ce_flags &= ~CE_HASHED;

        new->ce_namelen = namelen;
        memcpy(new->name, new_name, namelen + 1);
 
        new->ce_namelen = namelen;
        memcpy(new->name, new_name, namelen + 1);
 

diff --git a/unpack-trees.c b/unpack-trees.c
index 86f5f8837eecfbaca64674d454902d766689534b..36f3a7d06c73ecee27f4a5c0058b428023c086ad 100644 (file)
--- a/unpack-trees.c
+++ b/unpack-trees.c
@@ -105,7 +105,7 @@ void setup_unpack_trees_porcelain(struct unpack_trees_options *opts,
 static void do_add_entry(struct unpack_trees_options *o, struct cache_entry *ce,
                         unsigned int set, unsigned int clear)
 {
 static void do_add_entry(struct unpack_trees_options *o, struct cache_entry *ce,
                         unsigned int set, unsigned int clear)
 {

-       clear |= CE_HASHED | CE_UNHASHED;
+       clear |= CE_HASHED;

 
        if (set & CE_REMOVE)
                set |= CE_WT_REMOVE;
 
        if (set & CE_REMOVE)
                set |= CE_WT_REMOVE;