wildmatch test: use test_must_fail, not ! for test-wildmatch

Use of ! should be reserved for non-git programs that are assumed not
to fail, see README. With this change only
t/t0110-urlmatch-normalization.sh is still using this anti-pattern.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh
index 2f8a681c7299c652b424eef25095239929074def..fe0e5103a3146e4caac9bd2f7c84f162e9d7022d 100755 (executable)
--- a/t/t3070-wildmatch.sh
+++ b/t/t3070-wildmatch.sh
@@ -13,7 +13,7 @@ match() {
        elif test "$1" = 0
        then
                test_expect_success "wildmatch: no match '$2' '$3'" "
        elif test "$1" = 0
        then
                test_expect_success "wildmatch: no match '$2' '$3'" "

-                       ! test-wildmatch wildmatch '$2' '$3'
+                       test_must_fail test-wildmatch wildmatch '$2' '$3'

                "
        else
                test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false'
                "
        else
                test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false'


@@ -29,7 +29,7 @@ imatch() {
        elif test "$1" = 0
        then
                test_expect_success "iwildmatch: no match '$2' '$3'" "
        elif test "$1" = 0
        then
                test_expect_success "iwildmatch: no match '$2' '$3'" "

-                       ! test-wildmatch iwildmatch '$2' '$3'
+                       test_must_fail test-wildmatch iwildmatch '$2' '$3'

                "
        else
                test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false'
                "
        else
                test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false'


@@ -45,7 +45,7 @@ pathmatch() {
        elif test "$1" = 0
        then
                test_expect_success "pathmatch: no match '$2' '$3'" "
        elif test "$1" = 0
        then
                test_expect_success "pathmatch: no match '$2' '$3'" "

-                       ! test-wildmatch pathmatch '$2' '$3'
+                       test_must_fail test-wildmatch pathmatch '$2' '$3'

                "
        else
                test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false'
                "
        else
                test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false'