builtin/remote: quote remote name on error to display empty name

When adding new remote name with empty string, git will print the
following error message,

fatal: '' is not a valid remote name\n

But when removing remote name with empty string as input, git shows the
empty string without quote,

fatal: No such remote: \n

To make these error messages consistent, quote the name of the remote
that we tried and failed to find.

Signed-off-by: Shulhan <m.shulhan@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/remote.c b/builtin/remote.c
index 7876db1c20d317e28e4a84880197c6a690bf9ef6..5fd1012faaeceaa0d8db18c3a15310b0d8570043 100644 (file)
--- a/builtin/remote.c
+++ b/builtin/remote.c
@@ -625,7 +625,7 @@ static int mv(int argc, const char **argv)
 
        oldremote = remote_get(rename.old_name);
        if (!remote_is_configured(oldremote, 1))
 
        oldremote = remote_get(rename.old_name);
        if (!remote_is_configured(oldremote, 1))

-               die(_("No such remote: %s"), rename.old_name);
+               die(_("No such remote: '%s'"), rename.old_name);

 
        if (!strcmp(rename.old_name, rename.new_name) && oldremote->origin != REMOTE_CONFIG)
                return migrate_file(oldremote);
 
        if (!strcmp(rename.old_name, rename.new_name) && oldremote->origin != REMOTE_CONFIG)
                return migrate_file(oldremote);


@@ -761,7 +761,7 @@ static int rm(int argc, const char **argv)
 
        remote = remote_get(argv[1]);
        if (!remote_is_configured(remote, 1))
 
        remote = remote_get(argv[1]);
        if (!remote_is_configured(remote, 1))

-               die(_("No such remote: %s"), argv[1]);
+               die(_("No such remote: '%s'"), argv[1]);

 
        known_remotes.to_delete = remote;
        for_each_remote(add_known_remote, &known_remotes);
 
        known_remotes.to_delete = remote;
        for_each_remote(add_known_remote, &known_remotes);


@@ -860,7 +860,7 @@ static int get_remote_ref_states(const char *name,
 
        states->remote = remote_get(name);
        if (!states->remote)
 
        states->remote = remote_get(name);
        if (!states->remote)

-               return error(_("No such remote: %s"), name);
+               return error(_("No such remote: '%s'"), name);

 
        read_branches();
 
 
        read_branches();
 

diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
index 241e6a319df4cefa612b6744c79e72e5cf929462..d2a2cdd453396b1dba5525f32b6325ac8a10d95d 100755 (executable)
--- a/t/t5505-remote.sh
+++ b/t/t5505-remote.sh
@@ -145,7 +145,7 @@ test_expect_success 'remove remote protects local branches' '
 test_expect_success 'remove errors out early when deleting non-existent branch' '
        (
                cd test &&
 test_expect_success 'remove errors out early when deleting non-existent branch' '
        (
                cd test &&

-               echo "fatal: No such remote: foo" >expect &&
+               echo "fatal: No such remote: '\''foo'\''" >expect &&

                test_must_fail git remote rm foo 2>actual &&
                test_i18ncmp expect actual
        )
                test_must_fail git remote rm foo 2>actual &&
                test_i18ncmp expect actual
        )


@@ -173,7 +173,7 @@ test_expect_success 'remove remote with a branch without configured merge' '
 test_expect_success 'rename errors out early when deleting non-existent branch' '
        (
                cd test &&
 test_expect_success 'rename errors out early when deleting non-existent branch' '
        (
                cd test &&

-               echo "fatal: No such remote: foo" >expect &&
+               echo "fatal: No such remote: '\''foo'\''" >expect &&

                test_must_fail git remote rename foo bar 2>actual &&
                test_i18ncmp expect actual
        )
                test_must_fail git remote rename foo bar 2>actual &&
                test_i18ncmp expect actual
        )