Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
gitk: Rename 'tagcontents' to 'cached_tagcontent'
author
David Aguilar
<davvid@gmail.com>
Sat, 8 Sep 2012 19:53:16 +0000
(12:53 -0700)
committer
Junio C Hamano
<gitster@pobox.com>
Sun, 9 Sep 2012 03:25:09 +0000
(20:25 -0700)
Name the 'tagcontents' variable similarly to the rest of the
variables cleared in the changedrefs() function.
This makes the naming consistent and provides a hint that it
should be cleared when reloading gitk's cache.
Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
gitk
patch
|
blob
|
history
raw
|
patch
|
inline
| side by side (parent:
9b5bdf5
)
diff --git
a/gitk
b/gitk
index a124822626fa3c80231985552564675ff5e2ea81..6f24f53d217884607f1bf04c4b2f715cf6ad78ac 100755
(executable)
--- a/
gitk
+++ b/
gitk
@@
-10599,7
+10599,7
@@
proc movedhead {hid head} {
}
proc changedrefs {} {
}
proc changedrefs {} {
- global cached_dheads cached_dtags cached_atags
tagcontents
+ global cached_dheads cached_dtags cached_atags
cached_tagcontent
global arctags archeads arcnos arcout idheads idtags
foreach id [concat [array names idheads] [array names idtags]] {
global arctags archeads arcnos arcout idheads idtags
foreach id [concat [array names idheads] [array names idtags]] {
@@
-10611,7
+10611,7
@@
proc changedrefs {} {
}
}
}
}
}
}
- catch {unset
tagcontents
}
+ catch {unset
cached_tagcontent
}
catch {unset cached_dtags}
catch {unset cached_atags}
catch {unset cached_dheads}
catch {unset cached_dtags}
catch {unset cached_atags}
catch {unset cached_dheads}
@@
-10664,7
+10664,7
@@
proc listrefs {id} {
}
proc showtag {tag isnew} {
}
proc showtag {tag isnew} {
- global ctext
tagcontents
tagids linknum tagobjid
+ global ctext
cached_tagcontent
tagids linknum tagobjid
if {$isnew} {
addtohistory [list showtag $tag 0] savectextpos
if {$isnew} {
addtohistory [list showtag $tag 0] savectextpos
@@
-10673,13
+10673,13
@@
proc showtag {tag isnew} {
clear_ctext
settabs 0
set linknum 0
clear_ctext
settabs 0
set linknum 0
- if {![info exists
tagcontents
($tag)]} {
+ if {![info exists
cached_tagcontent
($tag)]} {
catch {
catch {
- set
tagcontents
($tag) [exec git cat-file tag $tag]
+ set
cached_tagcontent
($tag) [exec git cat-file tag $tag]
}
}
}
}
- if {[info exists
tagcontents
($tag)]} {
- set text $
tagcontents
($tag)
+ if {[info exists
cached_tagcontent
($tag)]} {
+ set text $
cached_tagcontent
($tag)
} else {
set text "[mc "Tag"]: $tag\n[mc "Id"]: $tagids($tag)"
}
} else {
set text "[mc "Tag"]: $tag\n[mc "Id"]: $tagids($tag)"
}