Make git-remote.perl "use strict" compliant

I was looking at some of the perl commands, and noticed that
git-remote was the only one to lack a 'use strict' pragma at the top,
which could be a good thing for its maintainability. Hopefully, the
required changes are minimal.

Signed-off-by: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/git-remote.perl b/git-remote.perl
index d13e4c1fea93f0c345f6638bfd8a3715c73fa693..5cd69513cf84111d1152d07f8cda77b201ffc416 100755 (executable)
--- a/git-remote.perl
+++ b/git-remote.perl
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 
 #!/usr/bin/perl -w
 

+use strict;

 use Git;
 my $git = Git->repository();
 
 use Git;
 my $git = Git->repository();
 


@@ -296,12 +297,13 @@ sub add_remote {
 
 sub update_remote {
        my ($name) = @_;
 
 sub update_remote {
        my ($name) = @_;

+       my @remotes;

 
         my $conf = $git->config("remotes." . $name);
        if (defined($conf)) {
                @remotes = split(' ', $conf);
        } elsif ($name eq 'default') {
 
         my $conf = $git->config("remotes." . $name);
        if (defined($conf)) {
                @remotes = split(' ', $conf);
        } elsif ($name eq 'default') {

-               undef @remotes;
+               @remotes = ();

                for (sort keys %$remote) {
                        my $do_fetch = $git->config_bool("remote." . $_ .
                                                    ".skipDefaultUpdate");
                for (sort keys %$remote) {
                        my $do_fetch = $git->config_bool("remote." . $_ .
                                                    ".skipDefaultUpdate");


@@ -341,7 +343,7 @@ sub rm_remote {
        my @refs = $git->command('for-each-ref',
                '--format=%(refname) %(objectname)', "refs/remotes/$name");
        for (@refs) {
        my @refs = $git->command('for-each-ref',
                '--format=%(refname) %(objectname)', "refs/remotes/$name");
        for (@refs) {

-               ($ref, $object) = split;
+               my ($ref, $object) = split;

                $git->command(qw(update-ref -d), $ref, $object);
        }
        return 0;
                $git->command(qw(update-ref -d), $ref, $object);
        }
        return 0;


@@ -352,7 +354,7 @@ sub add_usage {
        exit(1);
 }
 
        exit(1);
 }
 

-local $VERBOSE = 0;
+my $VERBOSE = 0;

 @ARGV = grep {
        if ($_ eq '-v' or $_ eq '--verbose') {
                $VERBOSE=1;
 @ARGV = grep {
        if ($_ eq '-v' or $_ eq '--verbose') {
                $VERBOSE=1;


@@ -395,7 +397,7 @@ sub add_usage {
                update_remote("default");
                exit(1);
        }
                update_remote("default");
                exit(1);
        }

-       for ($i = 1; $i < @ARGV; $i++) {
+       for (my $i = 1; $i < @ARGV; $i++) {

                update_remote($ARGV[$i]);
        }
 }
                update_remote($ARGV[$i]);
        }
 }