t1011 (sparse checkout): style nitpicks

Tweak the rest of the script to more closely follow the test
style guide.  Guarding setup commands with test_expect_success
makes it easy to see the scope in which some particular data is
used; removal of whitespace after >redirection operators is just
for consistency.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t1011-read-tree-sparse-checkout.sh b/t/t1011-read-tree-sparse-checkout.sh
index 62246dbf9546b9ee5ad4dbeb0b34de45a1671ac2..9189de8461825bec601760415fa6e5a9c8fc14c1 100755 (executable)
--- a/t/t1011-read-tree-sparse-checkout.sh
+++ b/t/t1011-read-tree-sparse-checkout.sh
@@ -1,16 +1,30 @@
 #!/bin/sh
 
 #!/bin/sh
 

-test_description='sparse checkout tests'
+test_description='sparse checkout tests
+
+* (tag: removed, master) removed
+| D    sub/added
+* (HEAD, tag: top) modified and added
+| M    init.t
+| A    sub/added
+* (tag: init) init
+  A    init.t
+'

 
 . ./test-lib.sh
 
 
 . ./test-lib.sh
 

-cat >expected <<EOF
-100644 77f0ba1734ed79d12881f81b36ee134de6a3327b 0      init.t
-100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0      sub/added
-EOF

 test_expect_success 'setup' '
 test_expect_success 'setup' '

+       cat >expected <<-\EOF &&
+       100644 77f0ba1734ed79d12881f81b36ee134de6a3327b 0       init.t
+       100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0       sub/added
+       EOF
+       cat >expected.swt <<-\EOF &&
+       H init.t
+       H sub/added
+       EOF
+

        test_commit init &&
        test_commit init &&

-       echo modified >> init.t &&
+       echo modified >>init.t &&

        mkdir sub &&
        touch sub/added &&
        git add init.t sub/added &&
        mkdir sub &&
        touch sub/added &&
        git add init.t sub/added &&


@@ -20,26 +34,22 @@ test_expect_success 'setup' '
        git commit -m removed &&
        git tag removed &&
        git checkout top &&
        git commit -m removed &&
        git tag removed &&
        git checkout top &&

-       git ls-files --stage > result &&
+       git ls-files --stage >result &&

        test_cmp expected result
 '
 
        test_cmp expected result
 '
 

-cat >expected.swt <<EOF
-H init.t
-H sub/added
-EOF

 test_expect_success 'read-tree without .git/info/sparse-checkout' '
        git read-tree -m -u HEAD &&
 test_expect_success 'read-tree without .git/info/sparse-checkout' '
        git read-tree -m -u HEAD &&

-       git ls-files --stage > result &&
+       git ls-files --stage >result &&

        test_cmp expected result &&
        test_cmp expected result &&

-       git ls-files -t > result &&
+       git ls-files -t >result &&

        test_cmp expected.swt result
 '
 
 test_expect_success 'read-tree with .git/info/sparse-checkout but disabled' '
        test_cmp expected.swt result
 '
 
 test_expect_success 'read-tree with .git/info/sparse-checkout but disabled' '

-       echo > .git/info/sparse-checkout
+       echo >.git/info/sparse-checkout

        git read-tree -m -u HEAD &&
        git read-tree -m -u HEAD &&

-       git ls-files -t > result &&
+       git ls-files -t >result &&

        test_cmp expected.swt result &&
        test -f init.t &&
        test -f sub/added
        test_cmp expected.swt result &&
        test -f init.t &&
        test -f sub/added


@@ -47,9 +57,9 @@ test_expect_success 'read-tree with .git/info/sparse-checkout but disabled' '
 
 test_expect_success 'read-tree --no-sparse-checkout with empty .git/info/sparse-checkout and enabled' '
        git config core.sparsecheckout true &&
 
 test_expect_success 'read-tree --no-sparse-checkout with empty .git/info/sparse-checkout and enabled' '
        git config core.sparsecheckout true &&

-       echo > .git/info/sparse-checkout &&
+       echo >.git/info/sparse-checkout &&

        git read-tree --no-sparse-checkout -m -u HEAD &&
        git read-tree --no-sparse-checkout -m -u HEAD &&

-       git ls-files -t > result &&
+       git ls-files -t >result &&

        test_cmp expected.swt result &&
        test -f init.t &&
        test -f sub/added
        test_cmp expected.swt result &&
        test -f init.t &&
        test -f sub/added


@@ -57,92 +67,90 @@ test_expect_success 'read-tree --no-sparse-checkout with empty .git/info/sparse-
 
 test_expect_success 'read-tree with empty .git/info/sparse-checkout' '
        git config core.sparsecheckout true &&
 
 test_expect_success 'read-tree with empty .git/info/sparse-checkout' '
        git config core.sparsecheckout true &&

-       echo > .git/info/sparse-checkout &&
+       echo >.git/info/sparse-checkout &&

        test_must_fail git read-tree -m -u HEAD &&
        test_must_fail git read-tree -m -u HEAD &&

-       git ls-files --stage > result &&
+       git ls-files --stage >result &&

        test_cmp expected result &&
        test_cmp expected result &&

-       git ls-files -t > result &&
+       git ls-files -t >result &&

        test_cmp expected.swt result &&
        test -f init.t &&
        test -f sub/added
 '
 
        test_cmp expected.swt result &&
        test -f init.t &&
        test -f sub/added
 '
 

-cat >expected.swt <<EOF
-S init.t
-H sub/added
-EOF

 test_expect_success 'match directories with trailing slash' '
 test_expect_success 'match directories with trailing slash' '

+       cat >expected.swt-noinit <<-\EOF &&
+       S init.t
+       H sub/added
+       EOF
+

        echo sub/ > .git/info/sparse-checkout &&
        git read-tree -m -u HEAD &&
        git ls-files -t > result &&
        echo sub/ > .git/info/sparse-checkout &&
        git read-tree -m -u HEAD &&
        git ls-files -t > result &&

-       test_cmp expected.swt result &&
+       test_cmp expected.swt-noinit result &&

        test ! -f init.t &&
        test -f sub/added
 '
 
        test ! -f init.t &&
        test -f sub/added
 '
 

-cat >expected.swt <<EOF
-H init.t
-H sub/added
-EOF

 test_expect_failure 'match directories without trailing slash' '
 test_expect_failure 'match directories without trailing slash' '

-       echo init.t > .git/info/sparse-checkout &&
-       echo sub >> .git/info/sparse-checkout &&
+       echo init.t >.git/info/sparse-checkout &&
+       echo sub >>.git/info/sparse-checkout &&

        git read-tree -m -u HEAD &&
        git read-tree -m -u HEAD &&

-       git ls-files -t > result &&
+       git ls-files -t >result &&

        test_cmp expected.swt result &&
        test ! -f init.t &&
        test -f sub/added
 '
 
        test_cmp expected.swt result &&
        test ! -f init.t &&
        test -f sub/added
 '
 

-cat >expected.swt <<EOF
-H init.t
-S sub/added
-EOF

 test_expect_success 'checkout area changes' '
 test_expect_success 'checkout area changes' '

-       echo init.t > .git/info/sparse-checkout &&
+       cat >expected.swt-nosub <<-\EOF &&
+       H init.t
+       S sub/added
+       EOF
+
+       echo init.t >.git/info/sparse-checkout &&

        git read-tree -m -u HEAD &&
        git read-tree -m -u HEAD &&

-       git ls-files -t > result &&
-       test_cmp expected.swt result &&
+       git ls-files -t >result &&
+       test_cmp expected.swt-nosub result &&

        test -f init.t &&
        test ! -f sub/added
 '
 
 test_expect_success 'read-tree updates worktree, absent case' '
        test -f init.t &&
        test ! -f sub/added
 '
 
 test_expect_success 'read-tree updates worktree, absent case' '

-       echo sub/added > .git/info/sparse-checkout &&
+       echo sub/added >.git/info/sparse-checkout &&

        git checkout -f top &&
        git read-tree -m -u HEAD^ &&
        test ! -f init.t
 '
 
 test_expect_success 'read-tree updates worktree, dirty case' '
        git checkout -f top &&
        git read-tree -m -u HEAD^ &&
        test ! -f init.t
 '
 
 test_expect_success 'read-tree updates worktree, dirty case' '

-       echo sub/added > .git/info/sparse-checkout &&
+       echo sub/added >.git/info/sparse-checkout &&

        git checkout -f top &&
        git checkout -f top &&

-       echo dirty > init.t &&
+       echo dirty >init.t &&

        git read-tree -m -u HEAD^ &&
        grep -q dirty init.t &&
        rm init.t
 '
 
 test_expect_success 'read-tree removes worktree, dirty case' '
        git read-tree -m -u HEAD^ &&
        grep -q dirty init.t &&
        rm init.t
 '
 
 test_expect_success 'read-tree removes worktree, dirty case' '

-       echo init.t > .git/info/sparse-checkout &&
+       echo init.t >.git/info/sparse-checkout &&

        git checkout -f top &&
        git checkout -f top &&

-       echo dirty > added &&
+       echo dirty >added &&

        git read-tree -m -u HEAD^ &&
        grep -q dirty added
 '
 
 test_expect_success 'read-tree adds to worktree, absent case' '
        git read-tree -m -u HEAD^ &&
        grep -q dirty added
 '
 
 test_expect_success 'read-tree adds to worktree, absent case' '

-       echo init.t > .git/info/sparse-checkout &&
+       echo init.t >.git/info/sparse-checkout &&

        git checkout -f removed &&
        git read-tree -u -m HEAD^ &&
        test ! -f sub/added
 '
 
 test_expect_success 'read-tree adds to worktree, dirty case' '
        git checkout -f removed &&
        git read-tree -u -m HEAD^ &&
        test ! -f sub/added
 '
 
 test_expect_success 'read-tree adds to worktree, dirty case' '

-       echo init.t > .git/info/sparse-checkout &&
+       echo init.t >.git/info/sparse-checkout &&

        git checkout -f removed &&
        mkdir sub &&
        git checkout -f removed &&
        mkdir sub &&

-       echo dirty > sub/added &&
+       echo dirty >sub/added &&

        git read-tree -u -m HEAD^ &&
        grep -q dirty sub/added
 '
        git read-tree -u -m HEAD^ &&
        grep -q dirty sub/added
 '