t4014: stop losing return codes of git commands

Currently, there are two ways where the return codes of Git commands are
lost. The first way is when a command is in the upstream of a pipe. In a
pipe, only the return code of the last command is used. Thus, all other
commands will have their return codes masked. Rewrite pipes so that
there are no Git commands upstream.

The other way is when a command is in a non-assignment subshell. The
return code will be lost in favour of the surrounding command's. Rewrite
instances of this such that Git commands output to a file and
surrounding commands only call subshells with non-Git commands.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index 67f4c62ed68e360761e0e6eb945e49ab9af597e6..83f52614d32a7a077d9d4070a8652415de869cc7 100755 (executable)
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -33,7 +33,8 @@ test_expect_success setup '
        git commit -m "Side changes #3 with \\n backslash-n in it." &&
 
        git checkout master &&
        git commit -m "Side changes #3 with \\n backslash-n in it." &&
 
        git checkout master &&

-       git diff-tree -p C2 | git apply --index &&
+       git diff-tree -p C2 >patch &&
+       git apply --index <patch &&

        test_tick &&
        git commit -m "Master accepts moral equivalent of #2" &&
 
        test_tick &&
        git commit -m "Master accepts moral equivalent of #2" &&
 


@@ -110,7 +111,8 @@ test_expect_success 'format-patch --ignore-if-in-upstream result applies' '
 '
 
 test_expect_success 'commit did not screw up the log message' '
 '
 
 test_expect_success 'commit did not screw up the log message' '

-       git cat-file commit side | grep "^Side .* with .* backslash-n"
+       git cat-file commit side >actual &&
+       grep "^Side .* with .* backslash-n" actual

 '
 
 test_expect_success 'format-patch did not screw up the log message' '
 '
 
 test_expect_success 'format-patch did not screw up the log message' '


@@ -119,7 +121,8 @@ test_expect_success 'format-patch did not screw up the log message' '
 '
 
 test_expect_success 'replay did not screw up the log message' '
 '
 
 test_expect_success 'replay did not screw up the log message' '

-       git cat-file commit rebuild-1 | grep "^Side .* with .* backslash-n"
+       git cat-file commit rebuild-1 >actual &&
+       grep "^Side .* with .* backslash-n" actual

 '
 
 test_expect_success 'extra headers' '
 '
 
 test_expect_success 'extra headers' '


@@ -153,63 +156,73 @@ test_expect_success 'extra headers with multiple To:s' '
 
 test_expect_success 'additional command line cc (ascii)' '
        git config --replace-all format.headers "Cc: R E Cipient <rcipient@example.com>" &&
 
 test_expect_success 'additional command line cc (ascii)' '
        git config --replace-all format.headers "Cc: R E Cipient <rcipient@example.com>" &&

-       git format-patch --cc="S E Cipient <scipient@example.com>" --stdout master..side | sed -e "/^\$/q" >patch5 &&
-       grep "^Cc: R E Cipient <rcipient@example.com>,\$" patch5 &&
-       grep "^ *S E Cipient <scipient@example.com>\$" patch5
+       git format-patch --cc="S E Cipient <scipient@example.com>" --stdout master..side >patch5 &&
+       sed -e "/^\$/q" patch5 >hdrs5 &&
+       grep "^Cc: R E Cipient <rcipient@example.com>,\$" hdrs5 &&
+       grep "^ *S E Cipient <scipient@example.com>\$" hdrs5

 '
 
 test_expect_failure 'additional command line cc (rfc822)' '
        git config --replace-all format.headers "Cc: R E Cipient <rcipient@example.com>" &&
 '
 
 test_expect_failure 'additional command line cc (rfc822)' '
        git config --replace-all format.headers "Cc: R E Cipient <rcipient@example.com>" &&

-       git format-patch --cc="S. E. Cipient <scipient@example.com>" --stdout master..side | sed -e "/^\$/q" >patch5 &&
-       grep "^Cc: R E Cipient <rcipient@example.com>,\$" patch5 &&
-       grep "^ *\"S. E. Cipient\" <scipient@example.com>\$" patch5
+       git format-patch --cc="S. E. Cipient <scipient@example.com>" --stdout master..side >patch5 &&
+       sed -e "/^\$/q" patch5 >hdrs5 &&
+       grep "^Cc: R E Cipient <rcipient@example.com>,\$" hdrs5 &&
+       grep "^ *\"S. E. Cipient\" <scipient@example.com>\$" hdrs5

 '
 
 test_expect_success 'command line headers' '
        git config --unset-all format.headers &&
 '
 
 test_expect_success 'command line headers' '
        git config --unset-all format.headers &&

-       git format-patch --add-header="Cc: R E Cipient <rcipient@example.com>" --stdout master..side | sed -e "/^\$/q" >patch6 &&
-       grep "^Cc: R E Cipient <rcipient@example.com>\$" patch6
+       git format-patch --add-header="Cc: R E Cipient <rcipient@example.com>" --stdout master..side >patch6 &&
+       sed -e "/^\$/q" patch6 >hdrs6 &&
+       grep "^Cc: R E Cipient <rcipient@example.com>\$" hdrs6

 '
 
 test_expect_success 'configuration headers and command line headers' '
        git config --replace-all format.headers "Cc: R E Cipient <rcipient@example.com>" &&
 '
 
 test_expect_success 'configuration headers and command line headers' '
        git config --replace-all format.headers "Cc: R E Cipient <rcipient@example.com>" &&

-       git format-patch --add-header="Cc: S E Cipient <scipient@example.com>" --stdout master..side | sed -e "/^\$/q" >patch7 &&
-       grep "^Cc: R E Cipient <rcipient@example.com>,\$" patch7 &&
-       grep "^ *S E Cipient <scipient@example.com>\$" patch7
+       git format-patch --add-header="Cc: S E Cipient <scipient@example.com>" --stdout master..side >patch7 &&
+       sed -e "/^\$/q" patch7 >hdrs7 &&
+       grep "^Cc: R E Cipient <rcipient@example.com>,\$" hdrs7 &&
+       grep "^ *S E Cipient <scipient@example.com>\$" hdrs7

 '
 
 test_expect_success 'command line To: header (ascii)' '
        git config --unset-all format.headers &&
 '
 
 test_expect_success 'command line To: header (ascii)' '
        git config --unset-all format.headers &&

-       git format-patch --to="R E Cipient <rcipient@example.com>" --stdout master..side | sed -e "/^\$/q" >patch8 &&
-       grep "^To: R E Cipient <rcipient@example.com>\$" patch8
+       git format-patch --to="R E Cipient <rcipient@example.com>" --stdout master..side >patch8 &&
+       sed -e "/^\$/q" patch8 >hdrs8 &&
+       grep "^To: R E Cipient <rcipient@example.com>\$" hdrs8

 '
 
 test_expect_failure 'command line To: header (rfc822)' '
 '
 
 test_expect_failure 'command line To: header (rfc822)' '

-       git format-patch --to="R. E. Cipient <rcipient@example.com>" --stdout master..side | sed -e "/^\$/q" >patch8 &&
-       grep "^To: \"R. E. Cipient\" <rcipient@example.com>\$" patch8
+       git format-patch --to="R. E. Cipient <rcipient@example.com>" --stdout master..side >patch8 &&
+       sed -e "/^\$/q" patch8 >hdrs8 &&
+       grep "^To: \"R. E. Cipient\" <rcipient@example.com>\$" hdrs8

 '
 
 test_expect_failure 'command line To: header (rfc2047)' '
 '
 
 test_expect_failure 'command line To: header (rfc2047)' '

-       git format-patch --to="R Ä Cipient <rcipient@example.com>" --stdout master..side | sed -e "/^\$/q" >patch8 &&
-       grep "^To: =?UTF-8?q?R=20=C3=84=20Cipient?= <rcipient@example.com>\$" patch8
+       git format-patch --to="R Ä Cipient <rcipient@example.com>" --stdout master..side >patch8 &&
+       sed -e "/^\$/q" patch8 >hdrs8 &&
+       grep "^To: =?UTF-8?q?R=20=C3=84=20Cipient?= <rcipient@example.com>\$" hdrs8

 '
 
 test_expect_success 'configuration To: header (ascii)' '
        git config format.to "R E Cipient <rcipient@example.com>" &&
 '
 
 test_expect_success 'configuration To: header (ascii)' '
        git config format.to "R E Cipient <rcipient@example.com>" &&

-       git format-patch --stdout master..side | sed -e "/^\$/q" >patch9 &&
-       grep "^To: R E Cipient <rcipient@example.com>\$" patch9
+       git format-patch --stdout master..side >patch9 &&
+       sed -e "/^\$/q" patch9 >hdrs9 &&
+       grep "^To: R E Cipient <rcipient@example.com>\$" hdrs9

 '
 
 test_expect_failure 'configuration To: header (rfc822)' '
        git config format.to "R. E. Cipient <rcipient@example.com>" &&
 '
 
 test_expect_failure 'configuration To: header (rfc822)' '
        git config format.to "R. E. Cipient <rcipient@example.com>" &&

-       git format-patch --stdout master..side | sed -e "/^\$/q" >patch9 &&
-       grep "^To: \"R. E. Cipient\" <rcipient@example.com>\$" patch9
+       git format-patch --stdout master..side >patch9 &&
+       sed -e "/^\$/q" patch9 >hdrs9 &&
+       grep "^To: \"R. E. Cipient\" <rcipient@example.com>\$" hdrs9

 '
 
 test_expect_failure 'configuration To: header (rfc2047)' '
        git config format.to "R Ä Cipient <rcipient@example.com>" &&
 '
 
 test_expect_failure 'configuration To: header (rfc2047)' '
        git config format.to "R Ä Cipient <rcipient@example.com>" &&

-       git format-patch --stdout master..side | sed -e "/^\$/q" >patch9 &&
-       grep "^To: =?UTF-8?q?R=20=C3=84=20Cipient?= <rcipient@example.com>\$" patch9
+       git format-patch --stdout master..side >patch9 &&
+       sed -e "/^\$/q" patch9 >hdrs9 &&
+       grep "^To: =?UTF-8?q?R=20=C3=84=20Cipient?= <rcipient@example.com>\$" hdrs9

 '
 
 # check_patch <patch>: Verify that <patch> looks like a half-sane
 '
 
 # check_patch <patch>: Verify that <patch> looks like a half-sane


@@ -221,76 +234,76 @@ check_patch () {
 }
 
 test_expect_success 'format.from=false' '
 }
 
 test_expect_success 'format.from=false' '

-       git -c format.from=false format-patch --stdout master..side |
-       sed -e "/^\$/q" >patch &&
+       git -c format.from=false format-patch --stdout master..side >patch &&
+       sed -e "/^\$/q" patch >hdrs &&

        check_patch patch &&
        check_patch patch &&

-       ! grep "^From: C O Mitter <committer@example.com>\$" patch
+       ! grep "^From: C O Mitter <committer@example.com>\$" hdrs

 '
 
 test_expect_success 'format.from=true' '
 '
 
 test_expect_success 'format.from=true' '

-       git -c format.from=true format-patch --stdout master..side |
-       sed -e "/^\$/q" >patch &&
-       check_patch patch &&
-       grep "^From: C O Mitter <committer@example.com>\$" patch
+       git -c format.from=true format-patch --stdout master..side >patch &&
+       sed -e "/^\$/q" patch >hdrs &&
+       check_patch hdrs &&
+       grep "^From: C O Mitter <committer@example.com>\$" hdrs

 '
 
 test_expect_success 'format.from with address' '
 '
 
 test_expect_success 'format.from with address' '

-       git -c format.from="F R Om <from@example.com>" format-patch --stdout master..side |
-       sed -e "/^\$/q" >patch &&
-       check_patch patch &&
-       grep "^From: F R Om <from@example.com>\$" patch
+       git -c format.from="F R Om <from@example.com>" format-patch --stdout master..side >patch &&
+       sed -e "/^\$/q" patch >hdrs &&
+       check_patch hdrs &&
+       grep "^From: F R Om <from@example.com>\$" hdrs

 '
 
 test_expect_success '--no-from overrides format.from' '
 '
 
 test_expect_success '--no-from overrides format.from' '

-       git -c format.from="F R Om <from@example.com>" format-patch --no-from --stdout master..side |
-       sed -e "/^\$/q" >patch &&
-       check_patch patch &&
-       ! grep "^From: F R Om <from@example.com>\$" patch
+       git -c format.from="F R Om <from@example.com>" format-patch --no-from --stdout master..side >patch &&
+       sed -e "/^\$/q" patch >hdrs &&
+       check_patch hdrs &&
+       ! grep "^From: F R Om <from@example.com>\$" hdrs

 '
 
 test_expect_success '--from overrides format.from' '
 '
 
 test_expect_success '--from overrides format.from' '

-       git -c format.from="F R Om <from@example.com>" format-patch --from --stdout master..side |
-       sed -e "/^\$/q" >patch &&
-       check_patch patch &&
-       ! grep "^From: F R Om <from@example.com>\$" patch
+       git -c format.from="F R Om <from@example.com>" format-patch --from --stdout master..side >patch &&
+       sed -e "/^\$/q" patch >hdrs &&
+       check_patch hdrs &&
+       ! grep "^From: F R Om <from@example.com>\$" hdrs

 '
 
 test_expect_success '--no-to overrides config.to' '
        git config --replace-all format.to \
                "R E Cipient <rcipient@example.com>" &&
 '
 
 test_expect_success '--no-to overrides config.to' '
        git config --replace-all format.to \
                "R E Cipient <rcipient@example.com>" &&

-       git format-patch --no-to --stdout master..side |
-       sed -e "/^\$/q" >patch10 &&
-       check_patch patch10 &&
-       ! grep "^To: R E Cipient <rcipient@example.com>\$" patch10
+       git format-patch --no-to --stdout master..side >patch10 &&
+       sed -e "/^\$/q" patch10 >hdrs10 &&
+       check_patch hdrs10 &&
+       ! grep "^To: R E Cipient <rcipient@example.com>\$" hdrs10

 '
 
 test_expect_success '--no-to and --to replaces config.to' '
        git config --replace-all format.to \
                "Someone <someone@out.there>" &&
        git format-patch --no-to --to="Someone Else <else@out.there>" \
 '
 
 test_expect_success '--no-to and --to replaces config.to' '
        git config --replace-all format.to \
                "Someone <someone@out.there>" &&
        git format-patch --no-to --to="Someone Else <else@out.there>" \

-               --stdout master..side |
-       sed -e "/^\$/q" >patch11 &&
-       check_patch patch11 &&
-       ! grep "^To: Someone <someone@out.there>\$" patch11 &&
-       grep "^To: Someone Else <else@out.there>\$" patch11
+               --stdout master..side >patch11 &&
+       sed -e "/^\$/q" patch11 >hdrs11 &&
+       check_patch hdrs11 &&
+       ! grep "^To: Someone <someone@out.there>\$" hdrs11 &&
+       grep "^To: Someone Else <else@out.there>\$" hdrs11

 '
 
 test_expect_success '--no-cc overrides config.cc' '
        git config --replace-all format.cc \
                "C E Cipient <rcipient@example.com>" &&
 '
 
 test_expect_success '--no-cc overrides config.cc' '
        git config --replace-all format.cc \
                "C E Cipient <rcipient@example.com>" &&

-       git format-patch --no-cc --stdout master..side |
-       sed -e "/^\$/q" >patch12 &&
-       check_patch patch12 &&
-       ! grep "^Cc: C E Cipient <rcipient@example.com>\$" patch12
+       git format-patch --no-cc --stdout master..side >patch12 &&
+       sed -e "/^\$/q" patch12 >hdrs12 &&
+       check_patch hdrs12 &&
+       ! grep "^Cc: C E Cipient <rcipient@example.com>\$" hdrs12

 '
 
 test_expect_success '--no-add-header overrides config.headers' '
        git config --replace-all format.headers \
                "Header1: B E Cipient <rcipient@example.com>" &&
 '
 
 test_expect_success '--no-add-header overrides config.headers' '
        git config --replace-all format.headers \
                "Header1: B E Cipient <rcipient@example.com>" &&

-       git format-patch --no-add-header --stdout master..side |
-       sed -e "/^\$/q" >patch13 &&
-       check_patch patch13 &&
-       ! grep "^Header1: B E Cipient <rcipient@example.com>\$" patch13
+       git format-patch --no-add-header --stdout master..side >patch13 &&
+       sed -e "/^\$/q" patch13 >hdrs13 &&
+       check_patch hdrs13 &&
+       ! grep "^Header1: B E Cipient <rcipient@example.com>\$" hdrs13

 '
 
 test_expect_success 'multiple files' '
 '
 
 test_expect_success 'multiple files' '


@@ -808,20 +821,25 @@ test_expect_success 'format-patch --ignore-if-in-upstream HEAD' '
        git format-patch --ignore-if-in-upstream HEAD
 '
 
        git format-patch --ignore-if-in-upstream HEAD
 '
 

-git_version="$(git --version | sed "s/.* //")"
+test_expect_success 'get git version' '
+       git_version=$(git --version) &&
+       git_version=${git_version##* }
+'

 
 signature() {
        printf "%s\n%s\n\n" "-- " "${1:-$git_version}"
 }
 
 test_expect_success 'format-patch default signature' '
 
 signature() {
        printf "%s\n%s\n\n" "-- " "${1:-$git_version}"
 }
 
 test_expect_success 'format-patch default signature' '

-       git format-patch --stdout -1 | tail -n 3 >output &&
+       git format-patch --stdout -1 >patch &&
+       tail -n 3 patch >output &&

        signature >expect &&
        test_cmp expect output
 '
 
 test_expect_success 'format-patch --signature' '
        signature >expect &&
        test_cmp expect output
 '
 
 test_expect_success 'format-patch --signature' '

-       git format-patch --stdout --signature="my sig" -1 | tail -n 3 >output &&
+       git format-patch --stdout --signature="my sig" -1 >patch &&
+       tail -n 3 patch >output &&

        signature "my sig" >expect &&
        test_cmp expect output
 '
        signature "my sig" >expect &&
        test_cmp expect output
 '


@@ -1606,19 +1624,40 @@ test_expect_success 'format-patch -o overrides format.outputDirectory' '
 
 test_expect_success 'format-patch --base' '
        git checkout patchid &&
 
 test_expect_success 'format-patch --base' '
        git checkout patchid &&

-       git format-patch --stdout --base=HEAD~3 -1 | tail -n 7 >actual1 &&
-       git format-patch --stdout --base=HEAD~3 HEAD~.. | tail -n 7 >actual2 &&
+
+       git format-patch --stdout --base=HEAD~3 -1 >patch &&
+       tail -n 7 patch >actual1 &&
+
+       git format-patch --stdout --base=HEAD~3 HEAD~.. >patch &&
+       tail -n 7 patch >actual2 &&
+

        echo >expect &&
        echo >expect &&

-       echo "base-commit: $(git rev-parse HEAD~3)" >>expect &&
-       echo "prerequisite-patch-id: $(git show --patch HEAD~2 | git patch-id --stable | awk "{print \$1}")" >>expect &&
-       echo "prerequisite-patch-id: $(git show --patch HEAD~1 | git patch-id --stable | awk "{print \$1}")" >>expect &&
+       git rev-parse HEAD~3 >commit-id-base &&
+       echo "base-commit: $(cat commit-id-base)" >>expect &&
+
+       git show --patch HEAD~2 >patch &&
+       git patch-id --stable <patch >patch.id.raw &&
+       awk "{print \"prerequisite-patch-id:\", \$1}" <patch.id.raw >>expect &&
+
+       git show --patch HEAD~1 >patch &&
+       git patch-id --stable <patch >patch.id.raw &&
+       awk "{print \"prerequisite-patch-id:\", \$1}" <patch.id.raw >>expect &&
+

        signature >>expect &&
        test_cmp expect actual1 &&
        test_cmp expect actual2 &&
        signature >>expect &&
        test_cmp expect actual1 &&
        test_cmp expect actual2 &&

+

        echo >fail &&
        echo >fail &&

-       echo "base-commit: $(git rev-parse HEAD~3)" >>fail &&
-       echo "prerequisite-patch-id: $(git show --patch HEAD~2 | git patch-id --unstable | awk "{print \$1}")" >>fail &&
-       echo "prerequisite-patch-id: $(git show --patch HEAD~1 | git patch-id --unstable | awk "{print \$1}")" >>fail &&
+       echo "base-commit: $(cat commit-id-base)" >>fail &&
+
+       git show --patch HEAD~2 >patch &&
+       git patch-id --unstable <patch >patch.id.raw &&
+       awk "{print \"prerequisite-patch-id:\", \$1}" <patch.id.raw >>fail &&
+
+       git show --patch HEAD~1 >patch &&
+       git patch-id --unstable <patch >patch.id.raw &&
+       awk "{print \"prerequisite-patch-id:\", \$1}" <patch.id.raw >>fail &&
+

        signature >>fail &&
        ! test_cmp fail actual1 &&
        ! test_cmp fail actual2
        signature >>fail &&
        ! test_cmp fail actual1 &&
        ! test_cmp fail actual2


@@ -1629,7 +1668,8 @@ test_expect_success 'format-patch --base errors out when base commit is in revis
        test_must_fail git format-patch --base=HEAD~1 -2 &&
        git format-patch --stdout --base=HEAD~2 -2 >patch &&
        grep "^base-commit:" patch >actual &&
        test_must_fail git format-patch --base=HEAD~1 -2 &&
        git format-patch --stdout --base=HEAD~2 -2 >patch &&
        grep "^base-commit:" patch >actual &&

-       echo "base-commit: $(git rev-parse HEAD~2)" >expect &&
+       git rev-parse HEAD~2 >commit-id-base &&
+       echo "base-commit: $(cat commit-id-base)" >expect &&

        test_cmp expect actual
 '
 
        test_cmp expect actual
 '
 


@@ -1668,7 +1708,8 @@ test_expect_success 'format-patch --base=auto' '
        test_commit N2 &&
        git format-patch --stdout --base=auto -2 >patch &&
        grep "^base-commit:" patch >actual &&
        test_commit N2 &&
        git format-patch --stdout --base=auto -2 >patch &&
        grep "^base-commit:" patch >actual &&

-       echo "base-commit: $(git rev-parse upstream)" >expect &&
+       git rev-parse upstream >commit-id-base &&
+       echo "base-commit: $(cat commit-id-base)" >expect &&

        test_cmp expect actual
 '
 
        test_cmp expect actual
 '
 


@@ -1705,7 +1746,8 @@ test_expect_success 'format-patch format.useAutoBaseoption' '
        git config format.useAutoBase true &&
        git format-patch --stdout -1 >patch &&
        grep "^base-commit:" patch >actual &&
        git config format.useAutoBase true &&
        git format-patch --stdout -1 >patch &&
        grep "^base-commit:" patch >actual &&

-       echo "base-commit: $(git rev-parse upstream)" >expect &&
+       git rev-parse upstream >commit-id-base &&
+       echo "base-commit: $(cat commit-id-base)" >expect &&

        test_cmp expect actual
 '
 
        test_cmp expect actual
 '
 


@@ -1714,7 +1756,8 @@ test_expect_success 'format-patch --base overrides format.useAutoBase' '
        git config format.useAutoBase true &&
        git format-patch --stdout --base=HEAD~1 -1 >patch &&
        grep "^base-commit:" patch >actual &&
        git config format.useAutoBase true &&
        git format-patch --stdout --base=HEAD~1 -1 >patch &&
        grep "^base-commit:" patch >actual &&

-       echo "base-commit: $(git rev-parse HEAD~1)" >expect &&
+       git rev-parse HEAD~1 >commit-id-base &&
+       echo "base-commit: $(cat commit-id-base)" >expect &&

        test_cmp expect actual
 '
 
        test_cmp expect actual
 '