http-fetch: do not use curl_message after releasing it

When curl_message is released using curl_multi_remove_handle(), it's
contents are undefined. Therefore, get the information before releasing it.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>

diff --git a/http-fetch.c b/http-fetch.c
index b12779dcb4a1ce92db94f545e1b78d7ea8b098e0..ea8af1b2defaf7e11dff0a09952234f3c7626376 100644 (file)
--- a/http-fetch.c
+++ b/http-fetch.c
@@ -578,6 +578,7 @@ void process_curl_messages(void)
 
        while (curl_message != NULL) {
                if (curl_message->msg == CURLMSG_DONE) {
 
        while (curl_message != NULL) {
                if (curl_message->msg == CURLMSG_DONE) {

+                       int curl_result = curl_message->data.result;

                        slot = active_queue_head;
                        while (slot != NULL &&
                               slot->curl != curl_message->easy_handle)
                        slot = active_queue_head;
                        while (slot != NULL &&
                               slot->curl != curl_message->easy_handle)


@@ -587,7 +588,7 @@ void process_curl_messages(void)
                                active_requests--;
                                slot->done = 1;
                                slot->in_use = 0;
                                active_requests--;
                                slot->done = 1;
                                slot->in_use = 0;

-                               slot->curl_result = curl_message->data.result;
+                               slot->curl_result = curl_result;

                                curl_easy_getinfo(slot->curl,
                                                  CURLINFO_HTTP_CODE,
                                                  &slot->http_code);
                                curl_easy_getinfo(slot->curl,
                                                  CURLINFO_HTTP_CODE,
                                                  &slot->http_code);


@@ -599,8 +600,7 @@ void process_curl_messages(void)
                                fprintf(stderr, "Received DONE message for unknown request!\n");
                        }
                        if (request != NULL) {
                                fprintf(stderr, "Received DONE message for unknown request!\n");
                        }
                        if (request != NULL) {

-                               request->curl_result =
-                                       curl_message->data.result;
+                               request->curl_result = curl_result;

                                request->http_code = slot->http_code;
                                request->slot = NULL;
                                request->state = COMPLETE;
                                request->http_code = slot->http_code;
                                request->slot = NULL;
                                request->state = COMPLETE;