CodingGuidelines: give an example for control statements

Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index 11704fb84cb3b9652223ad17631c999bafc268d8..47db6b3ce36a7964127c294740ca0073a6181050 100644 (file)
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -107,6 +107,17 @@ For shell scripts specifically (not exhaustive):
    "then" should be on the next line for if statements, and "do"
    should be on the next line for "while" and "for".
 
    "then" should be on the next line for if statements, and "do"
    should be on the next line for "while" and "for".
 

+       (incorrect)
+       if test -f hello; then
+               do this
+       fi
+
+       (correct)
+       if test -f hello
+       then
+               do this
+       fi
+

  - We prefer "test" over "[ ... ]".
 
  - We do not write the noiseword "function" in front of shell
  - We prefer "test" over "[ ... ]".
 
  - We do not write the noiseword "function" in front of shell