refs: remove some unnecessary handling of submodule == ""

The only external entry point to the ref_store lookup functions is
get_ref_store(), which ensures that submodule == "" is passed along as
NULL. So ref_store_init() and lookup_ref_store() don't have to handle
submodule being specified as the empty string.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/refs.c b/refs.c
index d7265ccc8f3c02b6c381f99497d0308a4e1caf8a..63484140f644185b8dcb7db170004ecf3b126495 100644 (file)
--- a/refs.c
+++ b/refs.c
@@ -1362,15 +1362,12 @@ static struct ref_store *submodule_ref_stores;
  * Return the ref_store instance for the specified submodule (or the
  * main repository if submodule is NULL). If that ref_store hasn't
  * been initialized yet, return NULL.
  * Return the ref_store instance for the specified submodule (or the
  * main repository if submodule is NULL). If that ref_store hasn't
  * been initialized yet, return NULL.

- *
- * For backwards compatibility, submodule=="" is treated the same as
- * submodule==NULL.

  */
 static struct ref_store *lookup_ref_store(const char *submodule)
 {
        struct ref_store *refs;
 
  */
 static struct ref_store *lookup_ref_store(const char *submodule)
 {
        struct ref_store *refs;
 

-       if (!submodule || !*submodule)
+       if (!submodule)

                return main_ref_store;
 
        for (refs = submodule_ref_stores; refs; refs = refs->next) {
                return main_ref_store;
 
        for (refs = submodule_ref_stores; refs; refs = refs->next) {


@@ -1384,9 +1381,6 @@ static struct ref_store *lookup_ref_store(const char *submodule)
 /*
  * Create, record, and return a ref_store instance for the specified
  * submodule (or the main repository if submodule is NULL).
 /*
  * Create, record, and return a ref_store instance for the specified
  * submodule (or the main repository if submodule is NULL).

- *
- * For backwards compatibility, submodule=="" is treated the same as
- * submodule==NULL.

  */
 static struct ref_store *ref_store_init(const char *submodule)
 {
  */
 static struct ref_store *ref_store_init(const char *submodule)
 {


@@ -1396,10 +1390,7 @@ static struct ref_store *ref_store_init(const char *submodule)
        if (!be)
                die("BUG: reference backend %s is unknown", be_name);
 
        if (!be)
                die("BUG: reference backend %s is unknown", be_name);
 

-       if (!submodule || !*submodule)
-               return be->init(NULL);
-       else
-               return be->init(submodule);
+       return be->init(submodule);

 }
 
 struct ref_store *get_ref_store(const char *submodule)
 }
 
 struct ref_store *get_ref_store(const char *submodule)