Merge branch 'ws/grep-quiet-no-pager' into maint
authorJunio C Hamano <gitster@pobox.com>
Sat, 28 Mar 2015 16:33:11 +0000 (09:33 -0700)
committerJunio C Hamano <gitster@pobox.com>
Sat, 28 Mar 2015 16:33:11 +0000 (09:33 -0700)
Even though "git grep --quiet" is run merely to ask for the exit
status, we spawned the pager regardless. Stop doing that.

* ws/grep-quiet-no-pager:
grep: fix "--quiet" overwriting current output

1  2 
builtin/grep.c
diff --combined builtin/grep.c
index e77f7cf109a02a10b2f38132b1a169b43d3c11d9,39fa4cb434e4e881d0997b4c8ca52b538b1bd6cc..fe7b9fdd93c78c302f5be32e51c59a31a87412fb
@@@ -361,7 -361,9 +361,7 @@@ static void run_pager(struct grep_opt *
                argv[i] = path_list->items[i].string;
        argv[path_list->nr] = NULL;
  
 -      if (prefix && chdir(prefix))
 -              die(_("Failed to chdir: %s"), prefix);
 -      status = run_command_v_opt(argv, RUN_USING_SHELL);
 +      status = run_command_v_opt_cd_env(argv, RUN_USING_SHELL, prefix, NULL);
        if (status)
                exit(status);
        free(argv);
@@@ -456,10 -458,10 +456,10 @@@ static int grep_tree(struct grep_opt *o
  }
  
  static int grep_object(struct grep_opt *opt, const struct pathspec *pathspec,
 -                     struct object *obj, const char *name, struct object_context *oc)
 +                     struct object *obj, const char *name, const char *path)
  {
        if (obj->type == OBJ_BLOB)
 -              return grep_sha1(opt, obj->sha1, name, 0, oc ? oc->path : NULL);
 +              return grep_sha1(opt, obj->sha1, name, 0, path);
        if (obj->type == OBJ_COMMIT || obj->type == OBJ_TREE) {
                struct tree_desc tree;
                void *data;
@@@ -501,7 -503,7 +501,7 @@@ static int grep_objects(struct grep_op
        for (i = 0; i < nr; i++) {
                struct object *real_obj;
                real_obj = deref_tag(list->objects[i].item, NULL, 0);
 -              if (grep_object(opt, pathspec, real_obj, list->objects[i].name, list->objects[i].context)) {
 +              if (grep_object(opt, pathspec, real_obj, list->objects[i].name, list->objects[i].path)) {
                        hit = 1;
                        if (opt->status_only)
                                break;
@@@ -641,7 -643,7 +641,7 @@@ int cmd_grep(int argc, const char **arg
                OPT_BOOL(0, "untracked", &untracked,
                        N_("search in both tracked and untracked files")),
                OPT_SET_INT(0, "exclude-standard", &opt_exclude,
 -                          N_("search also in ignored files"), 1),
 +                          N_("ignore files specified via '.gitignore'"), 1),
                OPT_GROUP(""),
                OPT_BOOL('v', "invert-match", &opt.invert,
                        N_("show non-matching lines")),
                        struct object *object = parse_object_or_die(sha1, arg);
                        if (!seen_dashdash)
                                verify_non_filename(prefix, arg);
 -                      add_object_array_with_context(object, arg, &list, xmemdupz(&oc, sizeof(struct object_context)));
 +                      add_object_array_with_path(object, arg, &list, oc.mode, oc.path);
                        continue;
                }
                if (!strcmp(arg, "--")) {
                }
        }
  
-       if (!show_in_pager)
+       if (!show_in_pager && !opt.status_only)
                setup_pager();
  
        if (!use_index && (untracked || cached))