sparse: Fix an "symbol 'format_subject' not declared" warning

In order to fix the warning, we add an extern declaration for this
function to the "commit.h" header file, along with all other non-
static functions defined in pretty.c. Also, we remove the function
declaration from builtin/shortlog.c, since it is no longer needed.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/shortlog.c b/builtin/shortlog.c
index f5efc67c9cad24fe54d5c6ab7257d38a4b1727ac..b6f4b0eb03b66dda2f691ff5c80b78321c1b701d 100644 (file)
--- a/builtin/shortlog.c
+++ b/builtin/shortlog.c
@@ -29,9 +29,6 @@ static int compare_by_number(const void *a1, const void *a2)
                return -1;
 }
 
                return -1;
 }
 

-const char *format_subject(struct strbuf *sb, const char *msg,
-                          const char *line_separator);
-

 static void insert_one_record(struct shortlog *log,
                              const char *author,
                              const char *oneline)
 static void insert_one_record(struct shortlog *log,
                              const char *author,
                              const char *oneline)

diff --git a/commit.h b/commit.h
index 41985130d1473573af2cfd4ca97a579e999b0c0b..b3c3bb70c5e737ed18df7ca665c85e339e1f3292 100644 (file)
--- a/commit.h
+++ b/commit.h
@@ -90,6 +90,8 @@ extern char *logmsg_reencode(const struct commit *commit,
 extern char *reencode_commit_message(const struct commit *commit,
                                     const char **encoding_p);
 extern void get_commit_format(const char *arg, struct rev_info *);
 extern char *reencode_commit_message(const struct commit *commit,
                                     const char **encoding_p);
 extern void get_commit_format(const char *arg, struct rev_info *);

+extern const char *format_subject(struct strbuf *sb, const char *msg,
+                                 const char *line_separator);

 extern void userformat_find_requirements(const char *fmt, struct userformat_want *w);
 extern void format_commit_message(const struct commit *commit,
                                  const char *format, struct strbuf *sb,
 extern void userformat_find_requirements(const char *fmt, struct userformat_want *w);
 extern void format_commit_message(const struct commit *commit,
                                  const char *format, struct strbuf *sb,