From: Mike Hommey <mh@glandium.org>
Date: Mon, 10 Dec 2007 21:36:08 +0000 (+0100)
Subject: Remove a CURLOPT_HTTPHEADER (un)setting
X-Git-Tag: v1.5.4-rc1~58
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/02dc534fc6eb8a08c686b7cb2d979545853889d0?hp=c20f290808efb85fbc7a57e7bc6eddeb4a0208a8

Remove a CURLOPT_HTTPHEADER (un)setting

Setting CURLOPT_HTTPHEADER doesn't add HTTP headers, but replaces whatever
set of headers was configured before, so setting to NULL doesn't have any
magic meaning, and is pretty much useless when setting to another list
right after.

Signed-off-by: Mike Hommey <mh@glandium.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/http.c b/http.c
index 146f62609d..ae57073a36 100644
--- a/http.c
+++ b/http.c
@@ -370,7 +370,6 @@ struct active_request_slot *get_active_slot(void)
 	slot->finished = NULL;
 	slot->callback_data = NULL;
 	slot->callback_func = NULL;
-	curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, NULL);
 	curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, pragma_header);
 	curl_easy_setopt(slot->curl, CURLOPT_ERRORBUFFER, curl_errorstr);
 	curl_easy_setopt(slot->curl, CURLOPT_CUSTOMREQUEST, NULL);