From: Jeff King <peff@peff.net>
Date: Thu, 24 Sep 2015 21:06:03 +0000 (-0400)
Subject: test-dump-cache-tree: avoid overflow of cache-tree name
X-Git-Tag: v2.8.3~32^2~14
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/04724222d5aad4da48674e69aab715273f05dded?ds=inline;hp=--cc

test-dump-cache-tree: avoid overflow of cache-tree name

When dumping a cache-tree, we sprintf sub-tree names directly
into a fixed-size buffer, which can overflow. We can
trivially fix this by converting to xsnprintf to at least
notice and die.

This probably should handle arbitrary-sized names, but
there's not much point. It's used only by the test scripts,
so the trivial fix is enough.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

04724222d5aad4da48674e69aab715273f05dded
diff --git a/test-dump-cache-tree.c b/test-dump-cache-tree.c
index 54c0872fcb..bb53c0aa65 100644
--- a/test-dump-cache-tree.c
+++ b/test-dump-cache-tree.c
@@ -47,7 +47,7 @@ static int dump_cache_tree(struct cache_tree *it,
 		struct cache_tree_sub *rdwn;
 
 		rdwn = cache_tree_sub(ref, down->name);
-		sprintf(path, "%s%.*s/", pfx, down->namelen, down->name);
+		xsnprintf(path, sizeof(path), "%s%.*s/", pfx, down->namelen, down->name);
 		if (dump_cache_tree(down->cache_tree, rdwn->cache_tree, path))
 			errs = 1;
 	}