From: Stefan Beller <sbeller@google.com>
Date: Mon, 9 Mar 2015 16:58:22 +0000 (-0700)
Subject: connect.c: do not leak "conn" after showing diagnosis
X-Git-Tag: v2.4.0-rc0~30^2~2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/04f20c04c6e51ee061a44406b9a73bf54683d8eb?ds=inline

connect.c: do not leak "conn" after showing diagnosis

When git_connect() is called to see how the URL is parsed for
debugging purposes with CONNECT_DIAG_URL set, the variable conn is
leaked.  At this point in the codeflow, it only has its memory and
no other resource is associated with it, so it is sufficient to
clean it up by just freeing it.

Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/connect.c b/connect.c
index ce0e121423..6090211fe9 100644
--- a/connect.c
+++ b/connect.c
@@ -739,6 +739,7 @@ struct child_process *git_connect(int fd[2], const char *url,
 
 				free(hostandport);
 				free(path);
+				free(conn);
 				return NULL;
 			} else {
 				ssh = getenv("GIT_SSH_COMMAND");