From: Jonathan Nieder Date: Wed, 11 Jan 2012 23:50:10 +0000 (-0600) Subject: unix-socket: do not let close() or chdir() clobber errno during cleanup X-Git-Tag: v1.7.9-rc2~3^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/06121a0a8328c8aaa7a023cf6ebb142e9dc2b45c?ds=inline;hp=06121a0a8328c8aaa7a023cf6ebb142e9dc2b45c unix-socket: do not let close() or chdir() clobber errno during cleanup unix_stream_connect and unix_stream_listen return -1 on error, with errno set by the failing underlying call to allow the caller to write a useful diagnosis. Unfortunately the error path involves a few system calls itself, such as close(), that can themselves touch errno. This is not as worrisome as it might sound. If close() fails, this just means substituting one meaningful error message for another, which is perfectly fine. However, when the call _succeeds_, it is allowed to (and sometimes might) clobber errno along the way with some undefined value, so it is good higiene to save errno and restore it immediately before returning to the caller. Do so. Signed-off-by: Jonathan Nieder Signed-off-by: Junio C Hamano ---