From: Jeff King <peff@peff.net>
Date: Thu, 21 Oct 2010 14:49:47 +0000 (-0400)
Subject: diff: report bogus input to -C/-M/-B
X-Git-Tag: v1.7.4-rc0~83^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/07cd7265274ba6aed2589e6b22eae7d413640037?hp=07cd7265274ba6aed2589e6b22eae7d413640037

diff: report bogus input to -C/-M/-B

We already detect invalid input to these functions, but we
simply exit with an error code, never saying anything as
simple as "your input was wrong". Let's fix that.

Before:

$ git diff -CM
$ echo $?
128

After:

$ git diff -CM
error: invalid argument to -C: M
$ echo $?
128

There should be no problems with having diff_opt_parse print
to stderr, as there is already precedent in complaining
about bogus --color and --output arguments.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---