From: René Scharfe <l.s.r@web.de>
Date: Wed, 7 Aug 2019 11:15:02 +0000 (+0200)
Subject: commit-graph: release strbufs after use
X-Git-Tag: v2.23.0-rc2~4^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/0aa6bce7365c97ab1e26791ee03b3a83f7e784dd

commit-graph: release strbufs after use

Signed-off-by: René Scharfe <l.s.r@web.de>
Acked-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/commit-graph.c b/commit-graph.c
index c91e6f0fb8..fa0760c430 100644
--- a/commit-graph.c
+++ b/commit-graph.c
@@ -432,6 +432,7 @@ static struct commit_graph *load_commit_graph_chain(struct repository *r, const
 
 	free(oids);
 	fclose(fp);
+	strbuf_release(&line);
 
 	return graph_chain;
 }
@@ -1179,7 +1180,7 @@ static int fill_oids_from_packs(struct write_commit_graph_context *ctx,
 	}
 
 	stop_progress(&ctx->progress);
-	strbuf_reset(&progress_title);
+	strbuf_release(&progress_title);
 	strbuf_release(&packname);
 
 	return 0;
@@ -1706,10 +1707,8 @@ static void expire_commit_graphs(struct write_commit_graph_context *ctx)
 	strbuf_addstr(&path, "/info/commit-graphs");
 	dir = opendir(path.buf);
 
-	if (!dir) {
-		strbuf_release(&path);
-		return;
-	}
+	if (!dir)
+		goto out;
 
 	strbuf_addch(&path, '/');
 	dirnamelen = path.len;
@@ -1738,6 +1737,9 @@ static void expire_commit_graphs(struct write_commit_graph_context *ctx)
 		if (!found)
 			unlink(path.buf);
 	}
+
+out:
+	strbuf_release(&path);
 }
 
 int write_commit_graph(const char *obj_dir,