From: SZEDER Gábor Date: Sat, 21 Nov 2015 14:46:40 +0000 (+0100) Subject: bash prompt: remove a redundant 'git diff' option X-Git-Tag: v2.6.4~3^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/0af9f7ecb8648ab1c6a090913e3df4a39f7c6754 bash prompt: remove a redundant 'git diff' option To get the dirty state indicator __git_ps1() runs 'git diff' with '--quiet --exit-code' options. '--quiet' already implies '--exit-code', so the latter is unnecessary and can be removed. Signed-off-by: SZEDER Gábor Signed-off-by: Jeff King --- diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh index 07b52bedf1..7a95fbdcfd 100644 --- a/contrib/completion/git-prompt.sh +++ b/contrib/completion/git-prompt.sh @@ -476,7 +476,7 @@ __git_ps1 () if [ -n "${GIT_PS1_SHOWDIRTYSTATE-}" ] && [ "$(git config --bool bash.showDirtyState)" != "false" ] then - git diff --no-ext-diff --quiet --exit-code || w="*" + git diff --no-ext-diff --quiet || w="*" if [ -n "$short_sha" ]; then git diff-index --cached --quiet HEAD -- || i="+" else