From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 26 Feb 2016 21:37:27 +0000 (-0800)
Subject: Merge branch 'ls/makefile-cflags-developer-tweak'
X-Git-Tag: v2.8.0-rc0~3
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/0f0dd370c84b4068bd80cbab30cb2ea67abedbe0?ds=inline;hp=-c

Merge branch 'ls/makefile-cflags-developer-tweak'

There is a new DEVELOPER knob that enables many compiler warning
options in the Makefile.

* ls/makefile-cflags-developer-tweak:
add DEVELOPER makefile knob to check for acknowledged warnings
---

0f0dd370c84b4068bd80cbab30cb2ea67abedbe0
diff --combined Makefile
index 10566d6481,7dc5b88e58..24bef8d428
--- a/Makefile
+++ b/Makefile
@@@ -380,6 -380,18 +380,18 @@@ ALL_CFLAGS = $(CPPFLAGS) $(CFLAGS
  ALL_LDFLAGS = $(LDFLAGS)
  STRIP ?= strip
  
+ ifdef DEVELOPER
+ CFLAGS += -Werror \
+ 	-Wdeclaration-after-statement \
+ 	-Wno-format-zero-length \
+ 	-Wold-style-definition \
+ 	-Woverflow \
+ 	-Wpointer-arith \
+ 	-Wstrict-prototypes \
+ 	-Wunused \
+ 	-Wvla
+ endif
+ 
  # Create as necessary, replace existing, make ranlib unneeded.
  ARFLAGS = rcs
  
@@@ -583,7 -595,6 +595,7 @@@ TEST_PROGRAMS_NEED_X += test-delt
  TEST_PROGRAMS_NEED_X += test-dump-cache-tree
  TEST_PROGRAMS_NEED_X += test-dump-split-index
  TEST_PROGRAMS_NEED_X += test-dump-untracked-cache
 +TEST_PROGRAMS_NEED_X += test-fake-ssh
  TEST_PROGRAMS_NEED_X += test-genrandom
  TEST_PROGRAMS_NEED_X += test-hashmap
  TEST_PROGRAMS_NEED_X += test-index-version