From: Charles Bailey <cbailey32@bloomberg.net>
Date: Fri, 17 Jul 2015 17:09:41 +0000 (+0100)
Subject: untracked: fix detection of uname(2) failure
X-Git-Tag: v2.5.1~16^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/100e433741715968b815e4b9fb3e638b625bf472?ds=inline;hp=--cc

untracked: fix detection of uname(2) failure

According to POSIX specification uname(2) must return -1 on failure
and a non-negative value on success.  Although many implementations
do return 0 on success it is valid to return any positive value for
success.  In particular, Solaris returns 1.

Signed-off-by: Charles Bailey <cbailey32@bloomberg.net>
Reviewed-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

100e433741715968b815e4b9fb3e638b625bf472
diff --git a/dir.c b/dir.c
index e9eaf97efe..8d15e475d4 100644
--- a/dir.c
+++ b/dir.c
@@ -1801,7 +1801,7 @@ static const char *get_ident_string(void)
 
 	if (sb.len)
 		return sb.buf;
-	if (uname(&uts))
+	if (uname(&uts) < 0)
 		die_errno(_("failed to get kernel name and information"));
 	strbuf_addf(&sb, "Location %s, system %s %s %s", get_git_work_tree(),
 		    uts.sysname, uts.release, uts.version);