From: Stefan Beller <sbeller@google.com>
Date: Sat, 15 Dec 2018 00:09:38 +0000 (-0800)
Subject: submodule: don't add submodule as odb for push
X-Git-Tag: v2.21.0-rc0~56^2~4
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/142e9f4432199cec5de418d74b37872d8330f696?hp=--cc

submodule: don't add submodule as odb for push

In push_submodule(), because we do not actually need access to objects
in the submodule, do not invoke add_submodule_odb().
(for_each_remote_ref_submodule() does not require access to those
objects, and the actual push is done by spawning another process,
which handles object access by itself.)

This code of push_submodule() is exercised in t5531 and continues
to work, showing that the submodule odbc is not needed.

Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

142e9f4432199cec5de418d74b37872d8330f696
diff --git a/submodule.c b/submodule.c
index 4486ff664b..d9c06767a1 100644
--- a/submodule.c
+++ b/submodule.c
@@ -1023,9 +1023,6 @@ static int push_submodule(const char *path,
 			  const struct string_list *push_options,
 			  int dry_run)
 {
-	if (add_submodule_odb(path))
-		return 1;
-
 	if (for_each_remote_ref_submodule(path, has_remote, NULL) > 0) {
 		struct child_process cp = CHILD_PROCESS_INIT;
 		argv_array_push(&cp.args, "push");