From: Johannes Schindelin Date: Thu, 14 Mar 2019 11:25:04 +0000 (-0700) Subject: parse-options: make OPT_ARGUMENT() more useful X-Git-Tag: v2.22.0-rc0~67^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/1a85b49b87af0e17a503b94df10d0b39472ad5b8?hp=1a85b49b87af0e17a503b94df10d0b39472ad5b8 parse-options: make OPT_ARGUMENT() more useful `OPT_ARGUMENT()` is intended to keep the specified long option in `argv` and not to do anything else. However, it would make a lot of sense for the caller to know whether this option was seen at all or not. For example, we want to teach `git difftool` to work outside of any Git worktree, but only when `--no-index` was specified. Note: nothing in Git uses OPT_ARGUMENT(). Even worse, looking through the commit history, one can easily see that nothing even ever used it, apart from the regression test. So not only do we make `OPT_ARGUMENT()` more useful, we are also about to introduce its first real user! Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano ---