From: Jeff King Date: Tue, 6 Feb 2018 08:43:19 +0000 (-0500) Subject: t0205: drop redundant test X-Git-Tag: v2.16.3~12^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/1cdc62f6f16e6dae4343824f08286015c8c4b9c2?ds=inline;hp=--cc t0205: drop redundant test We check that a shell variable is non-empty, and then we check that it's equal to a particular value. Just checking the latter covers both cases. I suspect the original was trying to give better output when the test fails, but using "-x" covers that these days. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- 1cdc62f6f16e6dae4343824f08286015c8c4b9c2 diff --git a/t/t0205-gettext-poison.sh b/t/t0205-gettext-poison.sh index 2361590d54..438e778d6a 100755 --- a/t/t0205-gettext-poison.sh +++ b/t/t0205-gettext-poison.sh @@ -7,10 +7,6 @@ test_description='Gettext Shell poison' . ./lib-gettext.sh -test_expect_success GETTEXT_POISON "sanity: \$GIT_INTERNAL_GETTEXT_SH_SCHEME is set (to $GIT_INTERNAL_GETTEXT_SH_SCHEME)" ' - test -n "$GIT_INTERNAL_GETTEXT_SH_SCHEME" -' - test_expect_success GETTEXT_POISON 'sanity: $GIT_INTERNAL_GETTEXT_SH_SCHEME" is poison' ' test "$GIT_INTERNAL_GETTEXT_SH_SCHEME" = "poison" '