From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 4 May 2017 13:57:33 +0000 (+0200)
Subject: fast-export: avoid leaking memory in handle_tag()
X-Git-Tag: v2.13.1~27^2~9
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/1efb1e9a21d16efddd1440bd2684bf19dc9546e0?ds=inline

fast-export: avoid leaking memory in handle_tag()

Reported by, you guessed it, Coverity.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/fast-export.c b/builtin/fast-export.c
index e0220630d0..64617ad8e3 100644
--- a/builtin/fast-export.c
+++ b/builtin/fast-export.c
@@ -734,6 +734,7 @@ static void handle_tag(const char *name, struct tag *tag)
 			     oid_to_hex(&tag->object.oid));
 		case DROP:
 			/* Ignore this tag altogether */
+			free(buf);
 			return;
 		case REWRITE:
 			if (tagged->type != OBJ_COMMIT) {
@@ -765,6 +766,7 @@ static void handle_tag(const char *name, struct tag *tag)
 	       (int)(tagger_end - tagger), tagger,
 	       tagger == tagger_end ? "" : "\n",
 	       (int)message_size, (int)message_size, message ? message : "");
+	free(buf);
 }
 
 static struct commit *get_commit(struct rev_cmdline_entry *e, char *full_name)