From: Jeff King Date: Fri, 20 Mar 2015 10:12:51 +0000 (-0400) Subject: t3600: fix &&-chain breakage for setup commands X-Git-Tag: v2.4.0-rc0~1^2~23 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/27a6625b13d7475d28f425adb2b7be221cf3c8e0?ds=sidebyside;hp=27a6625b13d7475d28f425adb2b7be221cf3c8e0 t3600: fix &&-chain breakage for setup commands As with the earlier patch to fix "trivial" &&-chain breakage, these missing "&&" operators are not a serious problem (e.g., we do not expect "echo" to fail). Ironically, however, inserting them shows that some of the commands _do_ fail. Specifically, some of the tests start by making sure we are at a commit with the string "content" in the file "foo". However, running "git commit" may fail because the previous test left us in that state already, and there is nothing to commit. We could remove these commands entirely, but they serve to document the test's assumptions, as well as make it robust when an earlier test has failed. We could use test_might_fail to handle all cases, but that would miss an unrelated failure to make the commit. Instead, we can just pass the --allow-empty flag to git-commit, which means that it will not complain if our setup is a noop. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano ---