From: Jeff King Date: Sat, 7 Jan 2017 01:16:24 +0000 (-0500) Subject: execv_dashed_external: use child_process struct X-Git-Tag: v2.11.1~2^2~2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/2b296c93d49d65303a4ce291225c8755eeab1ff8?hp=2b296c93d49d65303a4ce291225c8755eeab1ff8 execv_dashed_external: use child_process struct When we run a dashed external, we use the one-liner run_command_v_opt() to do so. Let's switch to using a child_process struct, which has two advantages: 1. We can drop all of the allocation and cleanup code for building our custom argv array, and just rely on the builtin argv_array (at the minor cost of doing a few extra mallocs). 2. We have access to the complete range of child_process options, not just the ones that the "_opt()" form can forward. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano ---