From: Junio C Hamano Date: Tue, 31 Jan 2017 21:32:07 +0000 (-0800) Subject: Merge branch 'jk/rebase-i-squash-count-fix' into maint X-Git-Tag: v2.11.1~11 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/2b3f61dc8b5ee4ee5b1c1ad8bdeebce52244a3a6?ds=inline;hp=-c Merge branch 'jk/rebase-i-squash-count-fix' into maint "git rebase -i" with a recent update started showing an incorrect count when squashing more than 10 commits. * jk/rebase-i-squash-count-fix: rebase--interactive: count squash commits above 10 correctly --- 2b3f61dc8b5ee4ee5b1c1ad8bdeebce52244a3a6 diff --combined git-rebase--interactive.sh index 41fd374c72,4bca73c94c..f5f58c483a --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@@ -93,17 -93,8 +93,17 @@@ eval GIT_CHERRY_PICK_HELP="$resolvemsg" export GIT_CHERRY_PICK_HELP -comment_char=$(git config --get core.commentchar 2>/dev/null | cut -c1) -: ${comment_char:=#} +comment_char=$(git config --get core.commentchar 2>/dev/null) +case "$comment_char" in +'' | auto) + comment_char="#" + ;; +?) + ;; +*) + comment_char=$(echo "$comment_char" | cut -c1) + ;; +esac warn () { printf '%s\n' "$*" >&2 @@@ -425,7 -416,7 +425,7 @@@ update_squash_messages () if test -f "$squash_msg"; then mv "$squash_msg" "$squash_msg".bak || exit count=$(($(sed -n \ - -e "1s/^$comment_char.*\([0-9][0-9]*\).*/\1/p" \ + -e "1s/^$comment_char[^0-9]*\([0-9][0-9]*\).*/\1/p" \ -e "q" < "$squash_msg".bak)+1)) { printf '%s\n' "$comment_char $(eval_ngettext \