From: Jeff King <peff@peff.net>
Date: Tue, 2 Apr 2013 07:40:31 +0000 (+0530)
Subject: t5516 (fetch-push): drop implicit arguments from helper functions
X-Git-Tag: v1.8.3-rc0~96^2~3
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/2e433b7895798d2936d9708da9f99bd190cd39fc?hp=2e433b7895798d2936d9708da9f99bd190cd39fc

t5516 (fetch-push): drop implicit arguments from helper functions

Many of the tests in t5516 look like:

mk_empty &&
git push testrepo ... &&
check_push_result $commit heads/master

It's reasonably easy to see what is being tested, with the
exception that "testrepo" is a magic global name (it is
implicitly used in the helpers, but we have to name it
explicitly when calling git directly). Let's make it
explicit when call the helpers, too. This is slightly more
typing, but makes the test snippets read more naturally.

It also makes it easy for future tests to use an alternate
or multiple repositories, without a proliferation of helper
functions.

[rr: fixed sloppy quoting]

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---