From: Johannes Schindelin Date: Fri, 9 Mar 2007 02:50:06 +0000 (+0100) Subject: git-bundle: prevent overwriting existing bundles X-Git-Tag: v1.5.1-rc1~50^2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/2e578f9a4f08ade4e8da52614c566e5dc1c8ca00 git-bundle: prevent overwriting existing bundles Not only does it prevent accidentally losing older bundles, but it also fixes a subtle bug: when writing into an existing bundle, git-pack-objects would not truncate the bundle. Therefore, fetching from the bundle would trigger an error in unpack-objects: "fatal: pack has junk at the end". Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- diff --git a/builtin-bundle.c b/builtin-bundle.c index ca3de60e44..55f6d0abcf 100644 --- a/builtin-bundle.c +++ b/builtin-bundle.c @@ -268,9 +268,9 @@ static int create_bundle(struct bundle_header *header, const char *path, struct rev_info revs; bundle_fd = (!strcmp(path, "-") ? 1 : - open(path, O_CREAT | O_WRONLY, 0666)); + open(path, O_CREAT | O_EXCL | O_WRONLY, 0666)); if (bundle_fd < 0) - return error("Could not write to '%s'", path); + return error("Could not create '%s': %s", path, strerror(errno)); /* write signature */ write_or_die(bundle_fd, bundle_signature, strlen(bundle_signature));