From: Junio C Hamano Date: Wed, 25 Feb 2015 23:40:19 +0000 (-0800) Subject: Merge branch 'jc/send-email-sensible-encoding' X-Git-Tag: v2.4.0-rc0~84 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/33a2eeaeade52afee9fb9ffdd2ae995acf3b7e4e?hp=75b49bb181555b25d316bbe427ba7feedd2a58da Merge branch 'jc/send-email-sensible-encoding' "git send-email" used to accept a mistaken "y" (or "yes") as an answer to "What encoding do you want to use [UTF-8]? " without questioning. Now it asks for confirmation when the answer looks too short to be a valid encoding name. * jc/send-email-sensible-encoding: send-email: ask confirmation if given encoding name is very short --- diff --git a/git-send-email.perl b/git-send-email.perl index 3092ab356c..848f17623a 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -752,6 +752,7 @@ sub file_declares_8bit_cte { print " $f\n"; } $auto_8bit_encoding = ask("Which 8bit encoding should I declare [UTF-8]? ", + valid_re => qr/.{4}/, confirm_only => 1, default => "UTF-8"); }