From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date: Sat, 19 May 2018 05:28:28 +0000 (+0200)
Subject: show-branch: note about its object flags usage
X-Git-Tag: v2.19.0-rc0~193^2~3
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/44cecbf8a02921a60eb6f7461f6877329edc8a0d?ds=inline;hp=--cc

show-branch: note about its object flags usage

This is another candidate for commit-slab. Keep Junio's observation in
code so we can search it later on when somebody wants to improve the
code.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

44cecbf8a02921a60eb6f7461f6877329edc8a0d
diff --git a/builtin/show-branch.c b/builtin/show-branch.c
index 29d15d16d2..f2e985c00a 100644
--- a/builtin/show-branch.c
+++ b/builtin/show-branch.c
@@ -22,6 +22,11 @@ static int showbranch_use_color = -1;
 
 static struct argv_array default_args = ARGV_ARRAY_INIT;
 
+/*
+ * TODO: convert this use of commit->object.flags to commit-slab
+ * instead to store a pointer to ref name directly. Then use the same
+ * UNINTERESTING definition from revision.h here.
+ */
 #define UNINTERESTING	01
 
 #define REV_SHIFT	 2
diff --git a/object.h b/object.h
index b8e70e5519..caf36529f3 100644
--- a/object.h
+++ b/object.h
@@ -43,6 +43,7 @@ struct object_array {
  * builtin/index-pack.c:                                     2021
  * builtin/pack-objects.c:                                   20
  * builtin/reflog.c:                   10--12
+ * builtin/show-branch.c:    0-------------------------------------------26
  * builtin/unpack-objects.c:                                 2021
  */
 #define FLAG_BITS  27