From: Steffen Prohaska Date: Sun, 13 Jul 2008 20:31:20 +0000 (+0200) Subject: help (Windows): Display HTML in default browser using Windows' shell API X-Git-Tag: v1.6.0-rc0~54^2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/4804aabcdbffb41dba96825ca2693ea45830a108?ds=inline;hp=4804aabcdbffb41dba96825ca2693ea45830a108 help (Windows): Display HTML in default browser using Windows' shell API The system's default browser for displaying HTML help pages is now used directly on Windows, instead of launching git-web--browser, which requires a Unix shell. Avoiding MSYS' bash when possible is good because it avoids potential path translation issues. In this case it is not too hard to avoid launching a shell, so let's avoid it. The Windows-specific code is implemented in compat/mingw.c to avoid platform-specific code in the main code base. On Windows, open_html is provided as a define. If open_html is not defined, git-web--browse is used. This approach avoids platform-specific ifdefs by using per-function ifdefs. The "ifndef open_html" together with the introductory comment should sufficiently warn developers, so that they hopefully will not break this mechanism. Signed-off-by: Steffen Prohaska Signed-off-by: Johannes Sixt Signed-off-by: Junio C Hamano ---