From: Junio C Hamano Date: Wed, 23 Mar 2011 04:37:59 +0000 (-0700) Subject: Merge branch 'jc/maint-rev-list-culled-boundary' X-Git-Tag: v1.7.5-rc0~43 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/4b28cd9f2fb755cdfe1b97130e84644ae932988c?hp=91b3c7ce8e189b90d3203265c9625806a15045e1 Merge branch 'jc/maint-rev-list-culled-boundary' * jc/maint-rev-list-culled-boundary: list-objects.c: don't add an unparsed NULL as a pending tree Conflicts: list-objects.c --- diff --git a/list-objects.c b/list-objects.c index 61f6cc98d9..838b6a732e 100644 --- a/list-objects.c +++ b/list-objects.c @@ -173,7 +173,12 @@ void traverse_commit_list(struct rev_info *revs, strbuf_init(&base, PATH_MAX); while ((commit = get_revision(revs)) != NULL) { - add_pending_tree(revs, commit->tree); + /* + * an uninteresting boundary commit may not have its tree + * parsed yet, but we are not going to show them anyway + */ + if (commit->tree) + add_pending_tree(revs, commit->tree); show_commit(commit, data); } for (i = 0; i < revs->pending.nr; i++) { diff --git a/t/t6110-rev-list-sparse.sh b/t/t6110-rev-list-sparse.sh new file mode 100755 index 0000000000..656ac7fe9d --- /dev/null +++ b/t/t6110-rev-list-sparse.sh @@ -0,0 +1,20 @@ +#!/bin/sh + +test_description='operations that cull histories in unusual ways' +. ./test-lib.sh + +test_expect_success setup ' + test_commit A && + test_commit B && + test_commit C && + git checkout -b side HEAD^ && + test_commit D && + test_commit E && + git merge master +' + +test_expect_success 'rev-list --first-parent --boundary' ' + git rev-list --first-parent --boundary HEAD^.. +' + +test_done