From: Jeff King Date: Mon, 12 Sep 2016 16:46:17 +0000 (-0400) Subject: add_delta_base_cache: use list_for_each_safe X-Git-Tag: v2.11.0-rc0~136^2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/4b92bae7d363adfe923337f198f9c98dc1c68e27 add_delta_base_cache: use list_for_each_safe We may remove elements from the list while we are iterating, which requires using a second temporary pointer. Otherwise stepping to the next element of the list might involve looking at freed memory (which generally works in practice, as we _just_ freed it, but of course is wrong to rely on; valgrind notices it). Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/sha1_file.c b/sha1_file.c index a57b71d133..132c861fdb 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -2187,11 +2187,11 @@ static void add_delta_base_cache(struct packed_git *p, off_t base_offset, void *base, unsigned long base_size, enum object_type type) { struct delta_base_cache_entry *ent = xmalloc(sizeof(*ent)); - struct list_head *lru; + struct list_head *lru, *tmp; delta_base_cached += base_size; - list_for_each(lru, &delta_base_cache_lru) { + list_for_each_safe(lru, tmp, &delta_base_cache_lru) { struct delta_base_cache_entry *f = list_entry(lru, struct delta_base_cache_entry, lru); if (delta_base_cached <= delta_base_cache_limit)